Skip to content

Conversation

kundaMwiza
Copy link
Collaborator

This causes an import failure if an external backend imports a module that uses torch._as_tensor_fullprec when it is being loaded.

Fixes #ISSUE_NUMBER

Copy link

pytorch-bot bot commented Jan 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145611

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9812113 with merge base bc62930 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kundaMwiza
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

Comment on moving device backends to the end of the module
@kundaMwiza kundaMwiza force-pushed the mwizak/fix-backend-autoload-import-order branch from 74c483a to 9812113 Compare January 24, 2025 19:52
@bdhirsh bdhirsh requested a review from albanD January 30, 2025 23:01
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 30, 2025
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@albanD
Copy link
Collaborator

albanD commented Jan 31, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 31, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 16:57 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 16:57 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 31, 2025 16:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants