Move module tests to common_nn #14578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

driazati wants to merge 6 commits into pytorch:master from driazati:move_nn

Contributor

driazati commented Nov 29, 2018

This moves new_module_tests from test_nn.py to common_nn.py so
that they can be used in test_jit.py without running any of
test_nn.py


          Move module tests to common_nn

8c80faf

This moves `new_module_tests` from `test_nn.py` to `common_nn.py` so
that they can be used in `test_jit.py` without running any of
`test_nn.py`

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito approved these changes

View reviewed changes

Contributor

zdevito left a comment

approved -- pay careful attention to any test errors though since moving stuff often causes issues.


          move missing function

b612401

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

davidriazati added 2 commits

November 29, 2018 16:13


          Merge branch 'master' of https://github.com/pytorch/pytorch into move_nn

806c877


          Skip failing batchnorm modules

ce8b14b

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Merge

676e9b6

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Skip failing layernorms (fix in followup)

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot closed this in

814b571

ezyang added the merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet