-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[WIP] Add test_torchinductor_opinfo.py to triton-cpu tests #145865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm guessing this isn't going to pass, but I want to see how long the CI takes. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145865
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit f768b96 with merge base a08f7f3 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
cc @kundaMwiza it looks like we do have triton-cpu tests running, but the opinfo tests aren't running. If you're interested (and if the CI doesn't take too long - which is what I'm testing in this PR) - we could probably enable these tests. But I'm guessing we'd have to do a first pass to mark all the failing tests as skipped, so that the CI isn't red. |
... actually, I realize we probably also need to set |
@davidberard98 Thanks. I did try running the tests locally and there were quite a lot of failures, some can be xfailed, but others result in a process crash. I ran the tests serially on a single node and it took 4 hours, but best to run it in pytorch CI to get a better view. |
The eager mode implementation of average pool nd returns an integer tensor if the input is also an integer tensor. This should also be preserved in inductor. Fixes pytest -k test_comprehensive_nn_functional_avg_pool2d_cpu_int64 error: Triton compilation failed: triton_poi_fused_avg_pool2d_0 See WIP #145865 (comment) to potentially enable such tests as they aren't enabled yet. Fixes #ISSUE_NUMBER Pull Request resolved: #146061 Approved by: https://github.com/eellison
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):
I'm guessing this isn't going to pass, but I want to see how long the CI takes.