Skip to content

Conversation

davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Jan 28, 2025

Stack from ghstack (oldest at bottom):

I'm guessing this isn't going to pass, but I want to see how long the CI takes.

I'm guessing this isn't going to pass, but I want to see how long the CI takes.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jan 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145865

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit f768b96 with merge base a08f7f3 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

davidberard98 added a commit that referenced this pull request Jan 28, 2025
I'm guessing this isn't going to pass, but I want to see how long the CI takes.

ghstack-source-id: e7fde07
Pull Request resolved: #145865
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@davidberard98 davidberard98 added keep-going Don't stop on first failure, keep running tests until the end ciflow/inductor labels Jan 28, 2025
@davidberard98
Copy link
Contributor Author

davidberard98 commented Jan 28, 2025

cc @kundaMwiza it looks like we do have triton-cpu tests running, but the opinfo tests aren't running.

If you're interested (and if the CI doesn't take too long - which is what I'm testing in this PR) - we could probably enable these tests. But I'm guessing we'd have to do a first pass to mark all the failing tests as skipped, so that the CI isn't red.

cc @minjang @int3

@davidberard98
Copy link
Contributor Author

... actually, I realize we probably also need to set torch._inductor.config.cpu_backend = "triton" to get these to run correctly.

@kundaMwiza
Copy link
Collaborator

@davidberard98 Thanks. I did try running the tests locally and there were quite a lot of failures, some can be xfailed, but others result in a process crash. I ran the tests serially on a single node and it took 4 hours, but best to run it in pytorch CI to get a better view.

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 21:13 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 21:13 Inactive
pytorchmergebot pushed a commit that referenced this pull request Mar 4, 2025
The eager mode implementation of average pool nd returns an integer tensor if the input is also an integer tensor. This should also be preserved in inductor.

Fixes pytest -k test_comprehensive_nn_functional_avg_pool2d_cpu_int64 error: Triton compilation failed: triton_poi_fused_avg_pool2d_0

See WIP #145865 (comment) to potentially enable such tests as they aren't enabled yet.

Fixes #ISSUE_NUMBER

Pull Request resolved: #146061
Approved by: https://github.com/eellison
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Mar 30, 2025
@github-actions github-actions bot closed this Apr 29, 2025
@github-actions github-actions bot deleted the gh/davidberard98/335/head branch June 7, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor keep-going Don't stop on first failure, keep running tests until the end Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants