realize stride symbols in estimate_runtime #146752
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146752
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 653709a with merge base 5d675de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
did you not have any luck tweaking my example to get a repro? I also found creating a repro for my case to be annoying because the partitioner "recompute" logic only fires in certain cases, so it took some time to figure out (code: https://github.com/pytorch/pytorch/pull/144097/files#diff-4c82a5798a61d4cceb176b2700ba6fdd7c3e72d575b8e7e22458589139459caaR5778)
I tried , but was not able to trigger is_continuous to be called on top of it? if you have thoughts lmk. |
idk how easy that would be, but if we are going that path i can just factor out the realize logic in a function and call it realize_symbols (tensor)->tensor |
Unfortuanlty could not create a local repo, or unit test. fix #146686 [ghstack-poisoned]
Unfortuanlty could not create a local repo, or unit test. fix #146686 [ghstack-poisoned]
Unfortuanlty could not create a local repo, or unit test. fix #146686 [ghstack-poisoned]
|
add unit test |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
| print(shape) | ||
| print(stride) |
There was a problem hiding this comment.
can we remove these prints?
5 participants
Stack from ghstack (oldest at bottom):
Unfortuanlty could not create a local repo, or unit test.
fix #146686