Skip to content

[FSDP2] Simplify shard_placement_fn in test #146847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FSDP2] Simplify shard_placement_fn in test #146847

wants to merge 1 commit into from

Conversation

tsunghsienlee
Copy link
Contributor

@tsunghsienlee tsunghsienlee commented Feb 10, 2025 •
edited by pytorch-bot bot
Loading

Summary: Found this while checking shard_placement_fn for Shampoo shard independent implementation.

Test Plan: OSS CI & tests

Differential Revision: D69412878

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 10, 2025

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @tsunghsienlee, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Feb 10, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146847

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6a81e40 with merge base dd2a943 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69412878

tsunghsienlee added a commit to tsunghsienlee/pytorch that referenced this pull request Feb 10, 2025
@tsunghsienlee @facebook-github-bot
[FSDP2] Simplify shard_placement_fn in test (pytorch#146847)
ce3d77d 
Summary:

Found this while checking `shard_placement_fn` for Shampoo shard independent implementation.

Test Plan: OSS CI & tests

Differential Revision: D69412878
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69412878

awgu
awgu approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 10, 2025
pytorch-bot bot pushed a commit that referenced this pull request Feb 13, 2025
@tsunghsienlee @facebook-github-bot
[FSDP2] Simplify shard_placement_fn in test (#146847)
61c3d1b 
Summary:

Found this while checking `shard_placement_fn` for Shampoo shard independent implementation.

Test Plan: OSS CI & tests

Reviewed By: awgu

Differential Revision: D69412878
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69412878

@tsunghsienlee @facebook-github-bot
[FSDP2] Simplify shard_placement_fn in test (pytorch#146847)
6a81e40 
Summary:

Found this while checking `shard_placement_fn` for Shampoo shard independent implementation.

Test Plan: OSS CI & tests

Reviewed By: awgu

Differential Revision: D69412878
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69412878

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awgu awgu awgu approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tsunghsienlee @facebook-github-bot @pytorchmergebot @awgu