[aoti_debug_printer][BE] explicitly dumping float32, bfloat16, float16 data type #147020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147020
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 5 Pending, 4 Unrelated FailuresAs of commit 53c9e00 with merge base 67cbbb2 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D69547344 |
YUNQIUGUO
force-pushed
the
export-D69547344
branch
from
1d023f9 to
0d86c6f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69547344 |
ColinPeppler
approved these changes
Feb 12, 2025
ColinPeppler
requested changes
Feb 12, 2025
YUNQIUGUO
force-pushed
the
export-D69547344
branch
from
0d86c6f to
d7a7734
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69547344 |
…6 data type (pytorch#147020) Summary: Per request, explicitly dumping the float dtypes for aten tensors in debug printing summary info. can be useful in identifying issues associated with "wrong AOTI lowering input precisions" before this diff: [ before_launch - triton_tem_fused_addmm_1 - buf1 ]: Number of elements: 6144 **Dtype: Float** Mean value: 0.0195527 Min value: 0 Max value: 4.55529 Device: cuda:0 Size: [1024, 6] Stride: [6, 1] Layout: Strided Is contiguous: 1 Requires grad: 0 after this diff: [ before_launch - triton_tem_fused_addmm_1 - buf1 ]: Number of elements: 6144 **Dtype: float32** Mean value: 0.0195527 Min value: 0 Max value: 4.55529 Device: cuda:0 Size: [1024, 6] Stride: [6, 1] Layout: Strided Is contiguous: 1 Requires grad: 0 Test Plan: ``` AOT_INDUCTOR_DEBUG_INTERMEDIATE_VALUE_PRINTER=2 TORCH_LOGS="+inductor, output_code" buck2 run -c fbcode.enable_gpu_sections=true -c fbcode.nvcc_arch=h100 @//mode/opt fbcode//caffe2/test/inductor:test_aot_inductor -- -r test_addmm ``` Reviewed By: hl475, jingsh, ColinPeppler Differential Revision: D69547344
YUNQIUGUO
force-pushed
the
export-D69547344
branch
from
d7a7734 to
53c9e00
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69547344 |
ColinPeppler
approved these changes
Feb 13, 2025
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
per request, explicitly dumping the float dtypes for aten tensors in debug printing summary info.
can be useful in identifying issues such as "wrong AOTI Lowering precisions"
Test Plan:
Differential Revision: D69547344
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov