Skip to content

Conversation

@StrongerXi
Copy link
Contributor

@StrongerXi StrongerXi commented Feb 13, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147152

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 607542e with merge base f95bdf5 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@StrongerXi
Copy link
Contributor Author

StrongerXi commented Feb 14, 2025

So we have a real failure in inductor, since it was assuming a dataclass input to torch.ops.higher_order.invoke_quant_packed to be a node that constructs the instance, yet this PR changes it into the dataclass instance itself. @zou3519

quant_options_node = kwargs.pop("quant_options", None)
if quant_options_node is not None:
assert isinstance(quant_options_node, torch.fx.Node)

@StrongerXi
Copy link
Contributor Author

Abandoning this stack, see #147530.

@StrongerXi StrongerXi closed this Feb 20, 2025
@github-actions github-actions bot deleted the gh/StrongerXi/86/head branch March 25, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants