Skip to content

Conversation

FFFrog
Copy link
Collaborator

@FFFrog FFFrog commented Feb 14, 2025

[ghstack-poisoned]
@FFFrog FFFrog requested review from a team and jeffdaily as code owners February 14, 2025 09:08
Copy link

pytorch-bot bot commented Feb 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147197

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5a54044 with merge base e8b20f6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added topic: not user facing topic category labels Feb 14, 2025
FFFrog added a commit that referenced this pull request Feb 14, 2025
As the title stated.

**Previous PR:**
#143908

**ISSUE Related:**
#147144

ghstack-source-id: b1918e6
Pull Request resolved: #147197
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the updates.
Let me create a todo that tries to keep those in sync

@malfet
Copy link
Contributor

malfet commented Feb 14, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 14, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@FFFrog
Copy link
Collaborator Author

FFFrog commented Feb 16, 2025

Looks good to me, thank you for the updates.

Let me create a todo that tries to keep those in sync

Thank you

@FFFrog
Copy link
Collaborator Author

FFFrog commented Feb 16, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/fffrog/41/orig onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/147197)

pytorchmergebot pushed a commit that referenced this pull request Feb 16, 2025
As the title stated.

**Previous PR:**
#143908

**ISSUE Related:**
#147144

ghstack-source-id: cf58b37
Pull Request resolved: #147197
[ghstack-poisoned]
[ghstack-poisoned]
FFFrog added a commit that referenced this pull request Feb 17, 2025
[ghstack-poisoned]
FFFrog added a commit that referenced this pull request Feb 18, 2025
@FFFrog
Copy link
Collaborator Author

FFFrog commented Feb 18, 2025

Sorry to bother @malfet again, I did some other changes to make CI happy , please take a look at it again, thank you a lot.

@malfet
Copy link
Contributor

malfet commented Feb 18, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants