-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Unify all sympy versions to avoid conflicts within PyTorch #147197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147197
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5a54044 with merge base e8b20f6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for the updates.
Let me create a todo that tries to keep those in sync
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Thank you |
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Successfully rebased |
As the title stated. There are some tiny diffrences between 1.13.1 and 1.13.3: 1.13.1: https://github.com/sympy/sympy/blob/2e489cf4b1438ae134ba98a44a80cc9add1306b0/sympy/core/numbers.py#L1591 1.13.3: https://github.com/sympy/sympy/blob/b4ce69ad5d40e4e545614b6c76ca9b0be0b98f0b/sympy/core/numbers.py#L1591 **Previous PR:** #143908 **ISSUE Related:** #147144 ghstack-source-id: 1449218 Pull Request resolved: #147197
As the title stated. There are some tiny diffrences between 1.13.1 and 1.13.3: 1.13.1: https://github.com/sympy/sympy/blob/2e489cf4b1438ae134ba98a44a80cc9add1306b0/sympy/core/numbers.py#L1591 1.13.3: https://github.com/sympy/sympy/blob/b4ce69ad5d40e4e545614b6c76ca9b0be0b98f0b/sympy/core/numbers.py#L1591 **Previous PR:** #143908 **ISSUE Related:** #147144 ghstack-source-id: 004a95d Pull Request resolved: #147197
Sorry to bother @malfet again, I did some other changes to make CI happy , please take a look at it again, thank you a lot. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
As the title stated.
There are some tiny diffrences between 1.13.1 and 1.13.3:
1.13.1:
https://github.com/sympy/sympy/blob/2e489cf4b1438ae134ba98a44a80cc9add1306b0/sympy/core/numbers.py#L1591
1.13.3:
https://github.com/sympy/sympy/blob/b4ce69ad5d40e4e545614b6c76ca9b0be0b98f0b/sympy/core/numbers.py#L1591
Previous PR:
#143908
ISSUE Related:
#147144