[AOTI][refactor] Consolidate CppBuilder.build and CppBuilder.build_fbcode #147975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code Summary: Let CppBuilder handle all the cpp build logic Differential Revision: D70141808
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147975
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 84819f1 with merge base 08f4c1a ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D70141808 |
angelayi
approved these changes
Feb 26, 2025
yushangdi
approved these changes
Feb 26, 2025
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
aditew01
pushed a commit
that referenced
this pull request
Feb 28, 2025
…code (#147975) Summary: Let CppBuilder handle all the cpp build logic Differential Revision: D70141808 Pull Request resolved: #147975 Approved by: https://github.com/angelayi, https://github.com/yushangdi
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 2, 2025
Summary: Fix fbcode test failures introduced by #147975. Make sure script.ld is copied to the build-time directory. Differential Revision: D70454149
desertfire
added a commit
that referenced
this pull request
Mar 2, 2025
Summary: Fix fbcode test failures introduced by #147975. Make sure script.ld is copied to the build-time directory. Differential Revision: D70454149
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
Summary: Fix fbcode test failures introduced by #147975. Make sure script.ld is copied to the build-time directory. Differential Revision: D70454149
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Mar 4, 2025
…code (pytorch#147975) Summary: Let CppBuilder handle all the cpp build logic Differential Revision: D70141808 Pull Request resolved: pytorch#147975 Approved by: https://github.com/angelayi, https://github.com/yushangdi
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 5, 2025
Summary: Fix fbcode test failures introduced by #147975. Make sure script.ld is copied to the build-time directory. Differential Revision: D70454149 Pull Request resolved: #148279 Approved by: https://github.com/zoranzhao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Let CppBuilder handle all the cpp build logic
Differential Revision: D70141808
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov