Move computeTensorTypeId from TensorImpl to TensorOptions #14824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D13349163 Differential Version: 65516789
Differential Revision: D13349164 Differential Version: 65516788
This was referenced Dec 5, 2018
Closed
Differential Revision: D13349163 Differential Version: 65565566
Differential Revision: D13349164 Differential Version: 65565557
Differential Revision: D13349163 Differential Version: 65592962
Differential Revision: D13349164 Differential Version: 65592971
Differential Revision: D13349164 Differential Version: 65631700
|
already in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #14746 Move TensorOptions, DefaultTensorOptions to c10 💚
:white_circle: #14747 Fix include paths for TensorOptions, DefaultTensorOptions, OptionsGuard 💛
:white_circle: #14658 Remove TensorImpl -> context_base dependency 💚
:white_circle: #14792 Remove unused TensorImpl dependencies 💛
:white_circle: #14793 Move WrapDimMinimal to c10 💛
:white_circle: #14794 Fix include path for WrapDimMinimal.h 💛
:white_circle: #14795 Move TensorImpl to c10 (yay!) 💛
:white_circle: #14816 Fix include paths for TensorImpl.h 💛
:white_circle: #14817 Move UndefinedTensorImpl to c10 (meh) 💛
:white_circle: #14818 Fix include paths for UndefinedTensorImpl.h 💛
:white_circle: #14819 Implement c10::Tensor 💛
:white_circle: #14820 Convert caffe2/aten Tensors to/from c10 💛
:black_circle: #14824 Move computeTensorTypeId from TensorImpl to TensorOptions 💛
This has nothing to do with TensorImpl.
Moving it to TensorOptions since it computes a TensorTypeId based on TensorOptions.
Differential Revision: D13349164