[mm_logs][ez] dump tuned mm info at lowering stage #148363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148363
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d1dd36a with merge base e4c558b ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
YUNQIUGUO
force-pushed
the
export-D70507880
branch
2 times, most recently
from
e4c47be to
46156dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70507880 |
|
This pull request was exported from Phabricator. Differential Revision: D70507880 |
YUNQIUGUO
force-pushed
the
export-D70507880
branch
from
46156dc to
4449118
Compare
|
I think |
|
This pull request was exported from Phabricator. Differential Revision: D70507880 |
YUNQIUGUO
force-pushed
the
export-D70507880
branch
from
4449118 to
c816591
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70507880 |
YUNQIUGUO
force-pushed
the
export-D70507880
branch
from
c816591 to
426cce7
Compare
YUNQIUGUO
added a commit
to YUNQIUGUO/pytorch
that referenced
this pull request
Mar 3, 2025
Summary: Pull Request resolved: pytorch#148363 As title. it would be beneficial for judging e2e perf improvement Easy first step to dump mm info at lowering stage. e.g. ``` fbsource/fbcode/caffe2/torch/_inductor/kernel/mm.py:525] [0/0] Tuned aten.addmm: m=16, n=6, k=16, layout=FixedLayout('cuda:0', torch.float32, size=[16, 6], stride=[6, 1]) ``` Next step: Dump overview info at `post_grad_graph` stage such as overall count of `aten.mm` in the graph & visualize to a table structure. Test Plan: by looking very hard in aot inductor bmm and mm UTs. Differential Revision: D70507880
YUNQIUGUO
force-pushed
the
export-D70507880
branch
from
426cce7 to
a4bebee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70507880 |
YUNQIUGUO
force-pushed
the
export-D70507880
branch
2 times, most recently
from
de8ab58 to
5852540
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70507880 |
YUNQIUGUO
force-pushed
the
export-D70507880
branch
from
5852540 to
1b63fc1
Compare
YUNQIUGUO
added a commit
to YUNQIUGUO/pytorch
that referenced
this pull request
Mar 4, 2025
Summary:
As title. it would be beneficial for judging e2e perf improvement
Easy first step to dump mm info at lowering stage.
e.g.
```
fbcode/caffe2/torch/_inductor/kernel/mm.py:525] [0/0] Tuned aten.addmm: m=16, n=6, k=16, mat1_dtype=torch.float32, mat2_dtype=torch.float32, output_layout=FixedLayout('cpu', torch.float32, size=[16, 6], stride=[6, 1])
```
Next step:
Dump overview info at `post_grad_graph` stage such as
overall count of `aten.mm` in the graph & visualize to a table structure.
Test Plan: by looking very hard in aot inductor bmm and mm UTs.
Reviewed By: ColinPeppler
Differential Revision: D70507880
YUNQIUGUO
force-pushed
the
export-D70507880
branch
from
1b63fc1 to
cb34040
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70507880 |
Summary:
As title. it would be beneficial for judging e2e perf improvement
Easy first step to dump mm info at lowering stage.
e.g.
```
fbcode/caffe2/torch/_inductor/kernel/mm.py:525] [0/0] Tuned aten.addmm: m=16, n=6, k=16, mat1_dtype=torch.float32, mat2_dtype=torch.float32, output_layout=FixedLayout('cpu', torch.float32, size=[16, 6], stride=[6, 1])
```
Next step:
Dump overview info at `post_grad_graph` stage such as
overall count of `aten.mm` in the graph & visualize to a table structure.
Test Plan: by looking very hard in aot inductor bmm and mm UTs.
Reviewed By: ColinPeppler
Differential Revision: D70507880
YUNQIUGUO
force-pushed
the
export-D70507880
branch
from
cb34040 to
d1dd36a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70507880 |
henrylhtsang
approved these changes
Mar 4, 2025
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title. it would be beneficial for judging e2e perf improvement
Easy first step to dump mm info at lowering stage.
e.g.
Next step:
Dump overview info at
post_grad_graphstage such asoverall count of
aten.mmin the graph & visualize to a table structure.Test Plan: by looking very hard in aot inductor bmm and mm UTs.
Differential Revision: D70507880
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov