Skip to content

[dynamo][guards] Fix mem leak caused be refcount increment #148480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[dynamo][guards] Fix mem leak caused be refcount increment #148480

wants to merge 1 commit into from

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Mar 4, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148480

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 82f3879 with merge base 439395c (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anijain2305 anijain2305 mentioned this pull request Mar 4, 2025
Closed
@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Mar 4, 2025
StrongerXi
StrongerXi approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@StrongerXi StrongerXi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀 oof

@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

@anijain2305
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: trunk / macos-py3-arm64 / build, trunk / libtorch-linux-focal-cuda12.4-py3.10-gcc9-debug / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@anijain2305 anijain2305 mentioned this pull request Mar 17, 2025
Closed
anijain2305 added a commit that referenced this pull request Mar 17, 2025
@anijain2305
Update on "[dynamo] Add mem leak test"
75a20a4 
Test for #148480


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Mar 18, 2025
@anijain2305
Update on "[dynamo] Add mem leak test"
cb4c8b3 
Test for #148480


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Mar 18, 2025
@anijain2305 @pytorchmergebot
[dynamo] Add mem leak test (#149358)
a8df5e5 
Test for #148480

Pull Request resolved: #149358
Approved by: https://github.com/malfet
@github-actions github-actions bot deleted the mem-leak1 branch April 4, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

@xmfan xmfan xmfan approved these changes

@williamwen42 williamwen42 williamwen42 approved these changes

@StrongerXi StrongerXi StrongerXi approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anijain2305 @pytorchmergebot @zou3519 @xmfan @williamwen42 @StrongerXi