Remove warnings on non-buffer tensor constants #148483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148483
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 9a3b444 with merge base 679e7d2 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
zhxchen17
approved these changes
Mar 4, 2025
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
zou3519
approved these changes
Mar 4, 2025
Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output. cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv Differential Revision: [D70577856](https://our.internmc.facebook.com/intern/diff/D70577856) [ghstack-poisoned]
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output. cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv Differential Revision: [D70577856](https://our.internmc.facebook.com/intern/diff/D70577856) [ghstack-poisoned]
tugsbayasgalan
added a commit
that referenced
this pull request
Mar 5, 2025
Pull Request resolved: #148483 Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output. cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @imported-using-ghimport Differential Revision: [D70577856](https://our.internmc.facebook.com/intern/diff/D70577856/) ghstack-source-id: 269864294
tugsbayasgalan
added a commit
to tugsbayasgalan/pytorch
that referenced
this pull request
Mar 5, 2025
Summary: Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output. cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv imported-using-ghimport Test Plan: Imported from OSS Reviewed By: zou3519 Differential Revision: D70577856 Pulled By: tugsbayasgalan
Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output. cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv Differential Revision: [D70577856](https://our.internmc.facebook.com/intern/diff/D70577856) [ghstack-poisoned]
Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output. cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv Differential Revision: [D70577856](https://our.internmc.facebook.com/intern/diff/D70577856) [ghstack-poisoned]
tugsbayasgalan
added a commit
that referenced
this pull request
Mar 6, 2025
Pull Request resolved: #148483 Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output. cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @imported-using-ghimport Differential Revision: [D70577856](https://our.internmc.facebook.com/intern/diff/D70577856/) ghstack-source-id: 24fb359
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output. cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv Differential Revision: [D70577856](https://our.internmc.facebook.com/intern/diff/D70577856) [ghstack-poisoned]
Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output. cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv Differential Revision: [D70577856](https://our.internmc.facebook.com/intern/diff/D70577856) [ghstack-poisoned]
tugsbayasgalan
added a commit
that referenced
this pull request
Mar 11, 2025
Pull Request resolved: #148483 cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @imported-using-ghimport Differential Revision: [D70577321](https://our.internmc.facebook.com/intern/diff/D70577321/) ghstack-source-id: 271094772
|
This pull request was exported from Phabricator. Differential Revision: D70577321 |
|
@pytorchbot merge -f "Landed internally" |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Some weirdness going on with ghimport/export. Actual diff for this PR is D70577321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Export already registers tensor constants directly in the graph and this is also true for Torchbind objects. This removes warning that pollutes the output.
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv
Differential Revision: D70577856