update torch.nn.RelicationPad{1,2,3}d deternimistic documentation #148633

1274085042 · 2025-03-06T03:57:39Z

#115395
This issue mentioned that when deterministic mode is turned on, added a decomp for replication_pad_{1,2,3}d
to make the backward function deterministic.
@malfet

pytorch-bot · 2025-03-06T03:57:42Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148633

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit b12c9a5 with merge base bc88f6f ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

trunk / linux-focal-rocm6.3-py3.10 / test (default, 1, 2, linux.rocm.gpu.2) (gh) (disabled by #68849, #107183 but the issue was closed recently and a rebase is needed to make it pass)
test_nn.py::TestNN::test_RNN_dropout_state
trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh) (similar failure)
inductor/test_provenance_tracing.py::TestProvenanceTracingArtifact::test_triton_kernel_to_post_grad_tracing_cpu

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / test (default, 3, 5, lf.ephemeral.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (trunk failure)
inductor/test_aot_inductor.py::AOTInductorTestABICompatibleGpu::test_free_inactive_buffer_cuda
pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / test (default, 4, 5, lf.ephemeral.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (trunk failure)
inductor/test_aot_inductor.py::AOTInductorTestABICompatibleCpu::test_update_inactive_constant_buffer_cpu
trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh) (trunk failure)
inductor/test_aot_inductor.py::AOTInductorTestABICompatibleCpu::test_update_inactive_constant_buffer_cpu

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.ephemeral.linux.2xlarge) (gh) (#144480)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

torch/__init__.py

1274085042 · 2025-03-10T06:00:03Z

@pytorchbot rebase -b main

pytorchmergebot · 2025-03-10T06:01:28Z

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

pytorchmergebot · 2025-03-10T06:01:33Z

Successfully rebased ReplicationPad_deterministic onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout ReplicationPad_deterministic && git pull --rebase)

1274085042 · 2025-03-10T06:04:01Z

@pytorchbot merge

pytorch-bot · 2025-03-10T06:04:05Z

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

1274085042 · 2025-03-10T07:04:02Z

@isuruf Could you help me merge it?

1274085042 · 2025-03-12T01:56:01Z

@malfet Could you help me merge it?

1274085042 · 2025-03-17T02:52:30Z

@colesbury Could you help me merge it?

1274085042 · 2025-03-18T11:22:44Z

@pytorchbot merge

pytorchmergebot · 2025-03-18T11:25:39Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-03-18T13:43:56Z

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_8-test / test

Details for Dev Infra team

Raised by workflow job

1274085042 · 2025-03-18T14:03:11Z

@pytorchbot rebase -b main

pytorchmergebot · 2025-03-18T14:04:40Z

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

pytorchmergebot · 2025-03-18T14:04:46Z

Successfully rebased ReplicationPad_deterministic onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout ReplicationPad_deterministic && git pull --rebase)

1274085042 · 2025-03-18T14:05:45Z

@pytorchbot merge

pytorch-bot · 2025-03-18T14:05:50Z

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

1274085042 · 2025-03-24T02:12:19Z

@colesbury Could you help me merge it?

colesbury · 2025-03-24T16:16:46Z

@pytorchbot merge

pytorchmergebot · 2025-03-24T16:18:35Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-03-24T18:21:40Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / test (default, 4, 5, lf.ephemeral.linux.g6.4xlarge.experimental.nvidia.gpu)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

1274085042 · 2025-03-25T01:53:52Z

@pytorchbot merge

pytorchmergebot · 2025-03-25T01:55:35Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

@malfet

…torch#148633) pytorch#115395 This issue mentioned that when deterministic mode is turned on, added a decomp for replication_pad_{1,2,3}d to make the backward function deterministic. @malfet Pull Request resolved: pytorch#148633 Approved by: https://github.com/isuruf

pytorchbot added the open source label Mar 6, 2025

colesbury added the topic: not user facing topic category label Mar 6, 2025

colesbury requested a review from svekars March 6, 2025 18:44

colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 6, 2025

isuruf reviewed Mar 6, 2025

View reviewed changes

torch/__init__.py Outdated Show resolved Hide resolved

1274085042 requested a review from isuruf March 7, 2025 02:27

isuruf approved these changes Mar 7, 2025

View reviewed changes

pytorchmergebot force-pushed the ReplicationPad_deterministic branch from 5901fca to 8863d09 Compare March 10, 2025 06:01

1274085042 requested a review from isuruf March 11, 2025 01:53

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 18, 2025

pytorchmergebot added the merging label Mar 18, 2025

pytorchmergebot removed the merging label Mar 18, 2025

1274085042 added 2 commits March 18, 2025 14:04

update torch.nn.RelicationPad{1,2,3}d deternimistic documentation

610fccc

update

b12c9a5

pytorchmergebot force-pushed the ReplicationPad_deterministic branch from 8863d09 to b12c9a5 Compare March 18, 2025 14:04

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Mar 18, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 24, 2025

pytorchmergebot added the merging label Mar 24, 2025

pytorchmergebot removed the merging label Mar 24, 2025

pytorchmergebot added the merging label Mar 25, 2025

pytorchmergebot added the Merged label Mar 25, 2025

pytorchmergebot closed this in 59d5cf0 Mar 25, 2025

pytorchmergebot removed the merging label Mar 25, 2025

update torch.nn.RelicationPad{1,2,3}d deternimistic documentation #148633

update torch.nn.RelicationPad{1,2,3}d deternimistic documentation #148633

Uh oh!

Conversation

1274085042 commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148633

✅ You can merge normally! (6 Unrelated Failures)

Uh oh!

Uh oh!

1274085042 commented Mar 10, 2025

Uh oh!

pytorchmergebot commented Mar 10, 2025

Uh oh!

pytorchmergebot commented Mar 10, 2025

Uh oh!

1274085042 commented Mar 10, 2025

Uh oh!

pytorch-bot bot commented Mar 10, 2025

Uh oh!

1274085042 commented Mar 10, 2025

Uh oh!

1274085042 commented Mar 12, 2025

Uh oh!

1274085042 commented Mar 17, 2025

Uh oh!

1274085042 commented Mar 18, 2025

Uh oh!

pytorchmergebot commented Mar 18, 2025

Merge started

Uh oh!

pytorchmergebot commented Mar 18, 2025

Merge failed

Uh oh!

1274085042 commented Mar 18, 2025

Uh oh!

pytorchmergebot commented Mar 18, 2025

Uh oh!

pytorchmergebot commented Mar 18, 2025

Uh oh!

1274085042 commented Mar 18, 2025

Uh oh!

pytorch-bot bot commented Mar 18, 2025

Uh oh!

1274085042 commented Mar 24, 2025

Uh oh!

colesbury commented Mar 24, 2025

Uh oh!

pytorchmergebot commented Mar 24, 2025

Merge started

Uh oh!

pytorchmergebot commented Mar 24, 2025

Merge failed

Uh oh!

1274085042 commented Mar 25, 2025

Uh oh!

pytorchmergebot commented Mar 25, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

1274085042 commented Mar 6, 2025 •

edited

Loading

pytorch-bot bot commented Mar 6, 2025 •

edited

Loading