Update the comment #148726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Microve wants to merge 1 commit into pytorch:main from Microve:export-D70747931

Contributor

Microve commented Mar 7, 2025 •

edited by pytorch-bot bot

Loading

Differential Revision: D70747931

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

pytorch-bot bot added ciflow/inductor module: inductor labels

pytorch-bot bot commented Mar 7, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148726

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 819513f with merge base 4c13a85 ():

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / unstable-linux-focal-cuda12.6-py3.10-gcc11-sm89-xfail / build (gh)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Mar 7, 2025

This pull request was exported from Phabricator. Differential Revision: D70747931

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Mar 7, 2025

This pull request was exported from Phabricator. Differential Revision: D70747931

Microve force-pushed the export-D70747931 branch from 36094c0 to 973c224 Compare

March 7, 2025 01:17

Contributor Author

Microve commented Mar 7, 2025

@pytorchbot label "topic: not user facing"

pytorch-bot bot added the topic: not user facing label

Microve force-pushed the export-D70747931 branch from 973c224 to c16ff0f Compare

March 7, 2025 03:20

Microve added a commit to Microve/pytorch that referenced this pull request


          Update the comment (pytorch#148726)

c16ff0f

Summary:

Update the comment for `reorder_for_compute_comm_overlap` which is not only used with fsdp

Test Plan: CI

Reviewed By: yf225

Differential Revision: D70747931

Contributor

facebook-github-bot commented Mar 7, 2025

This pull request was exported from Phabricator. Differential Revision: D70747931

Microve force-pushed the export-D70747931 branch from c16ff0f to 4920d68 Compare

March 7, 2025 07:15

Contributor

facebook-github-bot commented Mar 7, 2025

This pull request was exported from Phabricator. Differential Revision: D70747931

Microve added a commit to Microve/pytorch that referenced this pull request


          Update the comment (pytorch#148726)

4c0ec8f

Summary:
Pull Request resolved: pytorch#148726

Update the comment for `reorder_for_compute_comm_overlap` which is not only used with fsdp

Test Plan: CI

Reviewed By: yf225

Differential Revision: D70747931

Microve force-pushed the export-D70747931 branch from 4920d68 to 4c0ec8f Compare

March 7, 2025 07:19

yf225 approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

Microve force-pushed the export-D70747931 branch from 4c0ec8f to 684547d Compare

March 9, 2025 01:10

Contributor

facebook-github-bot commented Mar 9, 2025

This pull request was exported from Phabricator. Differential Revision: D70747931

Microve added a commit to Microve/pytorch that referenced this pull request


          Update the comment (pytorch#148726)

c537cce

Summary:
Pull Request resolved: pytorch#148726

Update the comment for `reorder_for_compute_comm_overlap` which is not only used with fsdp

Test Plan: CI

Reviewed By: yf225

Differential Revision: D70747931

Microve force-pushed the export-D70747931 branch 2 times, most recently from c537cce to c25b171 Compare

March 10, 2025 17:51


          Update the comment (pytorch#148726)

819513f

Summary:
Pull Request resolved: pytorch#148726

Update the comment for `reorder_for_compute_comm_overlap` which is not only used with fsdp

Test Plan: CI

Reviewed By: yf225

Differential Revision: D70747931

Contributor

facebook-github-bot commented Mar 10, 2025

This pull request was exported from Phabricator. Differential Revision: D70747931

Microve force-pushed the export-D70747931 branch from c25b171 to 819513f Compare

March 10, 2025 17:55

Contributor

facebook-github-bot commented Mar 11, 2025

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Mar 11, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

9fddbf3

pytorchmergebot removed the merging label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported Merged module: inductor topic: not user facing