Skip to content

Conversation

@xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Mar 7, 2025

For timeout reason, we can't turn on all Windows Inductor UTs in CI: #135927
And without the UTs, we can't ensure Windows inductor quality.

Intel team will do some local test for Windows inductor, but we still need to add a switch to turn on the full Windows inductor UTs.

The switch is an environment variable:

set TORCHINDUCTOR_WINDOWS_TESTS=1

After setup this environment variable, we can turn on all Windows inductor UTs, It will not affect to PyTorch CI.

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148733

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0eef9a5 with merge base 7ae0ce6 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn added ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks topic: not user facing topic category labels Mar 7, 2025
@xuhancn xuhancn changed the title add env_var switch to turn all Windows inductor UTs. [Inductor][Windows] add env_var switch to turn all Windows inductor UTs. Mar 7, 2025
@xuhancn xuhancn added module: windows Windows support for PyTorch intel This tag is for PR from Intel labels Mar 7, 2025
@xuhancn xuhancn marked this pull request as ready for review March 7, 2025 09:47
@xuhancn xuhancn requested review from jansel and malfet March 7, 2025 09:47
@xuhancn
Copy link
Collaborator Author

xuhancn commented Mar 7, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xu_add_switch_for_windows_inductor_uts onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout xu_add_switch_for_windows_inductor_uts && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the xu_add_switch_for_windows_inductor_uts branch from daca776 to 7a1ecce Compare March 7, 2025 09:49
jansel
jansel previously requested changes Mar 9, 2025
@xuhancn
Copy link
Collaborator Author

xuhancn commented Mar 10, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xu_add_switch_for_windows_inductor_uts onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout xu_add_switch_for_windows_inductor_uts && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the xu_add_switch_for_windows_inductor_uts branch from e29629f to 0eef9a5 Compare March 10, 2025 05:47
@xuhancn xuhancn requested a review from jansel March 10, 2025 13:26
@xuhancn xuhancn dismissed jansel’s stale review March 10, 2025 13:26

Done the change request.

@xuhancn
Copy link
Collaborator Author

xuhancn commented Mar 10, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 1, 4, linux.idc.xpu)

Details for Dev Infra team Raised by workflow job

@xuhancn
Copy link
Collaborator Author

xuhancn commented Mar 10, 2025

@pytorchbot merge -f "skip xpu timeout UTs."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn xuhancn deleted the xu_add_switch_for_windows_inductor_uts branch March 10, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks intel This tag is for PR from Intel Merged module: dynamo module: windows Windows support for PyTorch open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants