race condition fix of calling mutable_data inside a openmp region #14921
+42
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torch#14921) Summary: Pull Request resolved: pytorch#14921 Fix race condition introduced in D13188595 . Let's reminder ourselves "never call mutable_data from an OpenMP region!!!" Reviewed By: jianyuh Differential Revision: D13387692 fbshipit-source-id: 896e312b81c783eda6029caf507f1108978e5603
jspark1105
force-pushed
the
export-D13387692
branch
from
fa7d589 to
c863db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix race condition introduced in D13188595 .
Let's reminder ourselves "never call mutable_data from an OpenMP region!!!"
Differential Revision: D13387692