[dynamo][guards][serialization] Dont use ID_MATCH guard for bool and None #149228
Conversation
…None [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149228
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 80 Pending, 1 Unrelated FailureAs of commit 49adeff with merge base a089347 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…r bool and None" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
anijain2305
added
ciflow/trunk
…r bool and None" Doing this removes the need of collecting `id` and therefore facilitates serialization. It also improves readability with recompilations. Earlier, recompile message will just show the `id`. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "I wonder if this will fix the pr-time-benchmark regressions" -c weird |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…ool and None (#149228)" This reverts commit 5905bbe. Reverted #149228 on behalf of https://github.com/malfet due to I wonder if this will fix the pr-time-benchmark regressions ([comment](#149228 (comment)))
|
@anijain2305 your PR has been successfully reverted. |
|
I'm looking at https://hud.pytorch.org/hud/pytorch/pytorch/46226a90c827dae18aa436a74d954ab45d622d70/1?per_page=50&name_filter=pr_time_benchmarks&mergeLF=true and it feels like it was caused by https://hud.pytorch.org/pytorch/pytorch/commit/bfee141666319c80b6c5284394905beef8682515 but reverting it didn't help |
|
@pytorchbot merge -f "Alas, it does not fix it either" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Stack from ghstack (oldest at bottom):
Doing this removes the need of collecting
idand therefore facilitates serialization. It also improves readability with recompilations. Earlier, recompile message will just show theid.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames