Skip to content

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Mar 19, 2025

Ubuntu 18.04 end of life reached on May 31, 2023. These code isn't used now.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

@cyyever cyyever requested review from a team and jeffdaily as code owners March 19, 2025 03:46
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Mar 19, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149479

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 23 Pending, 1 Unrelated Failure

As of commit bddc3a0 with merge base 14dc6e7 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the module: rocm AMD GPU support for Pytorch label Mar 19, 2025
@cyyever cyyever requested a review from malfet March 19, 2025 03:46
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyyever
Copy link
Collaborator Author

cyyever commented Mar 19, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 19, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Mar 20, 2025

@pytorchbot merge -f "Image builds succeed"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the ununtu1804 branch March 22, 2025 00:48
amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
Ubuntu 18.04 end of life reached on May 31, 2023. These code isn't used now.

Pull Request resolved: pytorch#149479
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source release notes: releng release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants