Skip to content

[ROCm] Change LoadHIP to use find_file for rocm_version.h #149983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ROCm] Change LoadHIP to use find_file for rocm_version.h #149983

wants to merge 1 commit into from

Conversation

naromero77amd
Copy link
Collaborator

@naromero77amd naromero77amd commented Mar 25, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149983

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 80ca407 with merge base 7379c66 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch ciflow/rocm Trigger "default" config CI on ROCm labels Mar 25, 2025
@naromero77amd naromero77amd added the topic: not user facing topic category label Mar 25, 2025
@trixirt
Copy link

trixirt commented Mar 25, 2025

I believe this will work, thanks.

@naromero77amd
Copy link
Collaborator Author

I believe this will work, thanks.

Could you please confirm for us? Thanks.

@naromero77amd
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #149983, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@jeffdaily
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased rocm_find_version_h onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout rocm_find_version_h && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/rocm Trigger "default" config CI on ROCm label Mar 26, 2025
@jeffdaily
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 26, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

amathewc pushed a commit to amathewc/pytorch that referenced this pull request Apr 17, 2025
@naromero77amd @amathewc
[ROCm] Change LoadHIP to use find_file for rocm_version.h (pytorch#14…
2b90c1a 
…9983)

Fixes pytorch#149805

Pull Request resolved: pytorch#149983
Approved by: https://github.com/jeffdaily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong location of rocm_version.h for Fedora and OpenSUSE

5 participants

@naromero77amd @trixirt @pytorchmergebot @jeffdaily @pytorchbot