-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[CI][CUDA][UCC] Update test_c10d_ucc.py - remove xfailIfLinux because it now succeeds #150979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150979
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 29ab761 with merge base 10c51b1 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any area which commit caused this?
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Successfully rebased |
378e01c
to
12b9a20
Compare
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Successfully rebased |
12b9a20
to
29ab761
Compare
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
… it now succeeds (#150979) pytest -v test/distributed/test_c10d_ucc.py -k test_save_load ============================================================================================== test session starts ============================================================================================== platform linux -- Python 3.12.3, pytest-8.1.1, pluggy-1.5.0 -- /usr/bin/python cachedir: .pytest_cache hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase(PosixPath('/opt/pytorch/pytorch/.hypothesis/examples')) rootdir: /opt/pytorch/pytorch configfile: pytest.ini plugins: anyio-4.9.0, hypothesis-6.130.13, flakefinder-1.1.0, rerunfailures-15.0, xdist-3.6.1, xdoctest-1.0.2, typeguard-4.3.0 collected 63 items / 62 deselected / 1 selected Running 1 items in this shard test/distributed/test_c10d_ucc.py::DistributedDataParallelTest::test_save_load_checkpoint PASSED [65.2581s] [100%] ================================================================================== 1 passed, 62 deselected in 68.78s (0:01:08) @ptrblck @eqy @tinglvv @atalman @malfet Pull Request resolved: #150979 Approved by: https://github.com/eqy
… it now succeeds (pytorch#150979) pytest -v test/distributed/test_c10d_ucc.py -k test_save_load ============================================================================================== test session starts ============================================================================================== platform linux -- Python 3.12.3, pytest-8.1.1, pluggy-1.5.0 -- /usr/bin/python cachedir: .pytest_cache hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase(PosixPath('/opt/pytorch/pytorch/.hypothesis/examples')) rootdir: /opt/pytorch/pytorch configfile: pytest.ini plugins: anyio-4.9.0, hypothesis-6.130.13, flakefinder-1.1.0, rerunfailures-15.0, xdist-3.6.1, xdoctest-1.0.2, typeguard-4.3.0 collected 63 items / 62 deselected / 1 selected Running 1 items in this shard test/distributed/test_c10d_ucc.py::DistributedDataParallelTest::test_save_load_checkpoint PASSED [65.2581s] [100%] ================================================================================== 1 passed, 62 deselected in 68.78s (0:01:08) @ptrblck @eqy @tinglvv @atalman @malfet Pull Request resolved: pytorch#150979 Approved by: https://github.com/eqy
pytest -v test/distributed/test_c10d_ucc.py -k test_save_load
============================================================================================== test session starts ==============================================================================================
platform linux -- Python 3.12.3, pytest-8.1.1, pluggy-1.5.0 -- /usr/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase(PosixPath('/opt/pytorch/pytorch/.hypothesis/examples'))
rootdir: /opt/pytorch/pytorch
configfile: pytest.ini
plugins: anyio-4.9.0, hypothesis-6.130.13, flakefinder-1.1.0, rerunfailures-15.0, xdist-3.6.1, xdoctest-1.0.2, typeguard-4.3.0
collected 63 items / 62 deselected / 1 selected
Running 1 items in this shard
test/distributed/test_c10d_ucc.py::DistributedDataParallelTest::test_save_load_checkpoint PASSED [65.2581s] [100%]
================================================================================== 1 passed, 62 deselected in 68.78s (0:01:08)
@ptrblck @eqy @tinglvv @atalman @malfet
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k