[MegaCache] Rename the PGO artifact when used between different jobs #151482

oulgen · 2025-04-16T21:59:13Z

Stack from ghstack (oldest at bottom):

-> [MegaCache] Rename the PGO artifact when used between different jobs #151482

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

[ghstack-poisoned]

pytorch-bot · 2025-04-16T21:59:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151482

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (11 Unrelated Failures)

As of commit 80636f7 with merge base 682f09e ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
TypeError: unsupported operand type(s) for |: 'set' and 'list'
pull / linux-focal-cuda12.6-py3.10-gcc11 / test (default, 5, 5, lf.ephemeral.linux.4xlarge.nvidia.gpu) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-focal-cuda12.6-py3.10-gcc11-sm89 / test (default, 1, 5, lf.ephemeral.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-focal-py3.13-clang10 / test (default, 3, 5, lf.ephemeral.linux.4xlarge) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-focal-py3.13-clang10 / test (dynamo_wrapped, 3, 3, lf.ephemeral.linux.2xlarge) (gh) (trunk failure)
test_decomp.py::HasDecompTest::test_has_decomposition
pull / linux-focal-py3.9-clang10 / test (default, 2, 5, lf.ephemeral.linux.4xlarge) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-focal-py3.9-clang10 / test (dynamo_wrapped, 3, 3, lf.ephemeral.linux.2xlarge) (gh) (trunk failure)
test_decomp.py::HasDecompTest::test_has_decomposition
pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, lf.ephemeral.linux.4xlarge) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
pull / linux-jammy-py3.9-gcc11 / test (default, 3, 5, lf.ephemeral.linux.2xlarge) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh) (trunk failure)
dynamo/test_utils.py::TestDynamoTimed::test_dynamo_timed
trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh) (trunk failure)
test_decomp.py::HasDecompTest::test_has_decomposition

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 89cc6f1 Pull Request resolved: #151482

bobrenjc93 · 2025-04-16T23:58:00Z

torch/_dynamo/pgo.py

    return None


+def rewrite_cache_key_for_mega_cache(original_key: str) -> str:


Can you write a comment here (and ideally also in PR summary) explaining why this rewrite is needed for future readers? In particular I'd like to understand why this not a problem for normal caching? Is it because we are now using artifacts across different job names?

…ent jobs" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

ghstack-source-id: 4063c71 Pull Request resolved: #151482

oulgen · 2025-04-17T06:12:14Z

@pytorchbot merge

pytorchmergebot · 2025-04-17T06:14:24Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-04-17T06:30:22Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, lf.ephemeral.linux.4xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

oulgen · 2025-04-17T16:19:21Z

@pytorchbot merge

pytorchmergebot · 2025-04-17T16:22:53Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-04-17T16:23:07Z

Merge failed

Reason: 11 jobs have failed, first few of them are: pull / linux-focal-py3.13-clang10 / test (default, 3, 5, lf.ephemeral.linux.4xlarge), pull / linux-focal-py3.13-clang10 / test (dynamo_wrapped, 3, 3, lf.ephemeral.linux.2xlarge), pull / linux-focal-py3.9-clang10 / test (default, 2, 5, lf.ephemeral.linux.4xlarge), pull / linux-focal-py3.9-clang10 / test (dynamo_wrapped, 3, 3, lf.ephemeral.linux.2xlarge), pull / linux-jammy-py3.9-gcc11 / test (default, 3, 5, lf.ephemeral.linux.2xlarge)

Details for Dev Infra team

Raised by workflow job

oulgen · 2025-04-17T17:07:47Z

@pytorchbot merge -f "it says i can merge successfully"

pytorchmergebot · 2025-04-17T17:09:15Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[MegaCache] Rename the PGO artifact when used between different jobs

3d35b22

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo module: inductor labels Apr 16, 2025

oulgen added a commit that referenced this pull request Apr 16, 2025

[MegaCache] Rename the PGO artifact when used between different jobs

5e234fc

ghstack-source-id: 89cc6f1 Pull Request resolved: #151482

oulgen requested a review from jamesjwu April 16, 2025 21:59

oulgen added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Apr 16, 2025

oulgen requested review from bobrenjc93 and laithsakka April 16, 2025 21:59

bobrenjc93 approved these changes Apr 16, 2025

View reviewed changes

None on "[MegaCache] Rename the PGO artifact when used between differ…

80636f7

…ent jobs" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

oulgen added a commit that referenced this pull request Apr 17, 2025

[MegaCache] Rename the PGO artifact when used between different jobs

8df0da0

ghstack-source-id: 4063c71 Pull Request resolved: #151482

pytorchmergebot added the merging label Apr 17, 2025

pytorchmergebot removed the merging label Apr 17, 2025

jamesjwu approved these changes Apr 17, 2025

View reviewed changes

pytorchmergebot added the merging label Apr 17, 2025

pytorchmergebot removed the merging label Apr 17, 2025

pytorchmergebot added the merging label Apr 17, 2025

pytorchmergebot closed this in 8404c09 Apr 17, 2025

pytorchmergebot added Merged and removed merging labels Apr 17, 2025

github-actions bot deleted the gh/oulgen/27/head branch May 28, 2025 02:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MegaCache] Rename the PGO artifact when used between different jobs #151482

[MegaCache] Rename the PGO artifact when used between different jobs #151482

Uh oh!

oulgen commented Apr 16, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Apr 16, 2025 •

edited

Loading

Uh oh!

bobrenjc93 Apr 16, 2025

Uh oh!

oulgen commented Apr 17, 2025

Uh oh!

pytorchmergebot commented Apr 17, 2025

Uh oh!

pytorchmergebot commented Apr 17, 2025

Uh oh!

oulgen commented Apr 17, 2025

Uh oh!

pytorchmergebot commented Apr 17, 2025

Uh oh!

pytorchmergebot commented Apr 17, 2025

Uh oh!

oulgen commented Apr 17, 2025

Uh oh!

pytorchmergebot commented Apr 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		return None


		def rewrite_cache_key_for_mega_cache(original_key: str) -> str:

[MegaCache] Rename the PGO artifact when used between different jobs #151482

[MegaCache] Rename the PGO artifact when used between different jobs #151482

Uh oh!

Conversation

oulgen commented Apr 16, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151482

✅ You can merge normally! (11 Unrelated Failures)

Uh oh!

bobrenjc93 Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

oulgen commented Apr 17, 2025

Uh oh!

pytorchmergebot commented Apr 17, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 17, 2025

Merge failed

Uh oh!

oulgen commented Apr 17, 2025

Uh oh!

pytorchmergebot commented Apr 17, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 17, 2025

Merge failed

Uh oh!

oulgen commented Apr 17, 2025

Uh oh!

pytorchmergebot commented Apr 17, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oulgen commented Apr 16, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Apr 16, 2025 •

edited

Loading