Skip to content

Conversation

zeshengzong
Copy link
Contributor

@zeshengzong zeshengzong commented Apr 21, 2025

Fixes #151786

Change version in requirements of docs consistent with version in CI version file, which changed in #149331

Test Result

image

Copy link

pytorch-bot bot commented Apr 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151787

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c0c08ea with merge base bf28d1c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 21, 2025
@zeshengzong zeshengzong marked this pull request as ready for review April 21, 2025 11:38
malfet
malfet previously approved these changes Apr 21, 2025
@malfet
Copy link
Contributor

malfet commented Apr 21, 2025

LGTM, but if this file is not used by CI, perhaps it should be deleted? cc: @svekars

@malfet malfet dismissed their stale review April 21, 2025 13:45

Let's see how output looks like

@zeshengzong
Copy link
Contributor Author

LGTM, but if this file is not used by CI, perhaps it should be deleted?

Hi, I think it might be better to keep it for developer to build and verify docs on local machine.

@malfet
Copy link
Contributor

malfet commented Apr 22, 2025

@pytorchbot merge -f "Doc links are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to install document dependency locally

4 participants