Skip to content

[MPS] Implement _print_Trunc_to_Int #151964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MPS] Implement _print_Trunc_to_Int #151964

wants to merge 2 commits into from

Conversation

@dcci
Copy link
Member

@dcci dcci commented Apr 22, 2025 •
edited by pytorch-bot bot
Loading

@dcci
[MPS] Implement _print_Trunc_to_Int
e5ddf5b 
Fixes `test_device_assert_mps`
@dcci dcci added topic: not user facing topic category module: mps Related to Apple Metal Performance Shaders framework ciflow/mps Run MPS tests (subset of trunk) module: inductor labels Apr 22, 2025
@dcci dcci requested review from jansel and malfet April 22, 2025 23:16
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151964

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 64 Pending

As of commit 51b96ac with merge base 2f74cff (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet
malfet approved these changes Apr 22, 2025
View reviewed changes
dcci
dcci commented Apr 22, 2025
View reviewed changes
test/inductor/test_torchinductor.py
x1 = torch.randn(30, device=self.device)
x2 = torch.randn(36, device=self.device)
y = torch.ones(1, dtype=torch.float64, device=self.device)
dtype = torch.float64 if self.device != "mps" else torch.float32
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of saying self.device != mps can we say if the dtype is supported?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good followup PR, as I have this anti-pattern all over the place...

@malfet
Copy link
Contributor

malfet commented Apr 23, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) Merged module: inductor module: mps Related to Apple Metal Performance Shaders framework topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcci @malfet @pytorchmergebot