[Dynamo] Guard serialization for FUNCTION_MATCH #152727
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152727
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f045195 with merge base 9c11493 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 2, 2025
This was referenced May 2, 2025
jansel
approved these changes
May 4, 2025
This was referenced May 5, 2025
Unsupported because it uses unsupported ID_MATCH. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Unsupported because it uses unsupported ID_MATCH. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
|
Starting merge as part of PR stack under #152872 |
Unsupported because it uses unsupported ID_MATCH. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
|
Starting merge as part of PR stack under #152961 |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 7, 2025
Unsupported because it uses unsupported FUNCTION_MATCH. Pull Request resolved: #152728 Approved by: https://github.com/jansel ghstack dependencies: #152725, #152727
pytorchmergebot
pushed a commit
that referenced
this pull request
May 7, 2025
Tests only; no other changes needed. Test logic uses a tuple function input to trigger installation of a SEQUENCE_LENGTH guard. Pull Request resolved: #152730 Approved by: https://github.com/jansel ghstack dependencies: #152725, #152727, #152728
pytorchmergebot
pushed a commit
that referenced
this pull request
May 7, 2025
Tests serialization for TUPLE_ITERATOR_LEN; includes no non-test changes. Passing a tuple iterator as input results in the iterator being exhausted during testing. I threw together a super janky workaround via accepting a func for kwarg generation and replacing `frame_state.f_locals` with newly-generated kwargs to get fresh iterators, but insights into a better approach are welcome! Pull Request resolved: #152865 Approved by: https://github.com/jansel ghstack dependencies: #152725, #152727, #152728, #152730
pytorchmergebot
pushed a commit
that referenced
this pull request
May 7, 2025
Tests serialization for RANGE_ITERATOR_MATCH; includes no non-test changes. This PR handles iterator exhaustion issues by utilizing the janky solution from #152865; it passes a function to generate kwargs and `frame_state.f_locals` is updated with fresh iterators through a second kwarg generation pass after initial tracing. Pull Request resolved: #152872 Approved by: https://github.com/jansel ghstack dependencies: #152725, #152727, #152728, #152730, #152865
pytorchmergebot
pushed a commit
that referenced
this pull request
May 7, 2025
Not used anywhere: https://www.internalfb.com/code/search?q=repo%3Afbcode%20PYMODULE_MATCH Pull Request resolved: #152961 Approved by: https://github.com/jansel ghstack dependencies: #152725, #152727, #152728, #152730, #152865, #152872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Unsupported because it uses unsupported ID_MATCH.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames