Skip to content

Conversation

@yuchengliu1
Copy link
Contributor

@yuchengliu1 yuchengliu1 commented May 6, 2025

Fixes #152251

get_export_declaration introduced one more ')' in Windows platform, which cause this pattern of function declaration different with Linux.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented May 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152939

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 37e6201 with merge base 9c11493 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@leslie-fang-intel leslie-fang-intel added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels May 6, 2025
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 6, 2025
Copy link
Collaborator

@leslie-fang-intel leslie-fang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the summary for this PR like what issue are fixing here and also take a look of the CI failure.

@yuchengliu1
Copy link
Contributor Author

@shoumikhin @huydhn @malfet This pr failed in url-lint. This failure seems not related to my code change. Should I add label skip-url-lint in this pr

@yuchengliu1 yuchengliu1 changed the title get right function definition on windows inductor get right function declaration on windows inductor May 7, 2025
@shoumikhin
Copy link
Contributor

@yuchengliu1 yes, please add that label

@xuhancn
Copy link
Collaborator

xuhancn commented May 7, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix_152251 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_152251 && git pull --rebase)

@pytorch-bot pytorch-bot bot removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels May 7, 2025
@xuhancn xuhancn added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels May 7, 2025
@xuhancn
Copy link
Collaborator

xuhancn commented May 8, 2025

Local validated pass:
image

@jansel could you please review it?

@xuhancn xuhancn requested a review from jansel May 8, 2025 05:51
@xuhancn
Copy link
Collaborator

xuhancn commented May 8, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source skip-url-lint topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows inductor genarated code without function declaration, and compile failed on MSVC.

8 participants