Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented May 8, 2025

As devs has been complaining it's failing. Completely remove them from lint.yml as #153157 moved it to nightly

See #152439 as well as #152884 and #152489 for more details

Was introduced in #152377

@malfet malfet requested a review from a team as a code owner May 8, 2025 15:26
Copy link

pytorch-bot bot commented May 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153156

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 55 Pending

As of commit f9c75cc with merge base 6a80064 (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 8, 2025
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is safe, but why not move it to unstable instead?

Feels kinda messy to leave dead code hanging around.

As devs has been complaining it's failing
@malfet malfet force-pushed the malfet-patch-1 branch from f577a13 to f9c75cc Compare May 8, 2025 17:31
@malfet
Copy link
Contributor Author

malfet commented May 8, 2025

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the malfet-patch-1 branch June 17, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants