[dynamic shapes] simplify int(x / y) pattern #153477
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153477
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 268e407 with merge base 82dc345 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D74664734 |
| r"your code specialized it to be a constant \(28\)(.*\n)*.*" | ||
| ), | ||
| ): | ||
| export(model, input1, dynamic_shapes=dynamic_shapes, strict=False) |
There was a problem hiding this comment.
didn't investigate more, but strict=True doesn't emit this guard; the original test case passes
|
Hmm are you sure this is sound? Do you need to limit to only positive integers? |
it's only for divisible terms, so I don't think we'd apply this here?
I don't think it's limited, unless I'm missing something... |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Summary: detects symint specializations where we didn't previously Differential Revision: D74664734
|
Successfully rebased |
pytorchmergebot
force-pushed
the
export-D74664734
branch
from
839916e to
268e407
Compare
|
@pytorchbot merge |
Merge failedReason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR! Details for Dev Infra teamRaised by workflow job |
|
@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Fixes #138853
Summary: Converts
TruncToInt(IntTrueDiv(x / y))tox // yif divisible, helps detect symint specializations where we didn't previouslyDifferential Revision: D74664734
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv