[AOTI] Skip a rocm test #153828
Closed
[AOTI] Skip a rocm test #153828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Skip test_aot_inductor_package.test_compile_after_package. #150739 added an opt-in feature which doesn't work for rocm yet. [ghstack-poisoned]
pytorch-bot
bot
added
ciflow/inductor
ciflow/rocm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153828
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 56 PendingAs of commit e495890 with merge base c45515c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
May 19, 2025
|
@pytorchbot merge -f "hot forward fix" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
desertfire
added a commit
that referenced
this pull request
May 20, 2025
Summary: * When package_cpp_only is specified, generate kernel file names with unique kernel names to make the final packaged package files more readable. Assert on unique_kernel_names in case somehow it was explicitly set to False. * Fix a rocm test skip, see #153828 [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
May 20, 2025
…nly" Summary: * When package_cpp_only is specified, generate kernel file names with unique kernel names to make the final packaged package files more readable. Assert on unique_kernel_names in case somehow it was explicitly set to False. * Fix a rocm test skip, see #153828 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
May 20, 2025
Summary: * When package_cpp_only is specified, generate kernel file names with unique kernel names to make the final packaged package files more readable. Assert on unique_kernel_names in case somehow it was explicitly set to False. * Fix a rocm test skip, see #153828 ghstack-source-id: eb4be8f Pull Request resolved: #153948
pytorchmergebot
pushed a commit
that referenced
this pull request
May 20, 2025
Summary: * When package_cpp_only is specified, generate kernel file names with unique kernel names to make the final packaged package files more readable. Assert on unique_kernel_names in case somehow it was explicitly set to False. * Fix a rocm test skip, see #153828 Pull Request resolved: #153948 Approved by: https://github.com/angelayi, https://github.com/yushangdi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Skip test_aot_inductor_package.test_compile_after_package. #150739 added an opt-in feature which doesn't work for rocm yet.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov