Add resolve in add decomp to enable view

[cz2h]

Fixes #148950.

During the construction of graph and running the node of add under interpreter, the functional argument of conj complex tensor gets cloned. This result in always having .is_conj() evaluted to false in decomposition function.

Propose a fix of calling resolve_conj() in the decomposition of complex tensor add.

Test as below
python test/dynamo/test_repros.py ReproTests.test_add_complex_conj

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153945

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 416d3fc with merge base db01f10 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[cz2h]

@pytorchbot label "topic: open source"
@pytorchbot label "topic: not user facing"

[pytorch-bot]

Didn't find following labels among repository labels: topic: opensurce

[cz2h]

@pytorchbot label "topic: not user facing"

[jansel]

Can we add a test for what this is fixing?

[jansel]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 1 jobs have failed, first few of them are: Apply lint suggestions

Details for Dev Infra team

Raised by workflow job

[eellison]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Successfully rebased resolve-conj-during-add onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout resolve-conj-during-add && git pull --rebase)

[eellison]

test failures?

[cz2h]

test failures?

Looks like resolving conj at decomp is losing track of the original memory address. I am thinking if we can apply fix of resoloving args and creating alias after tracing before decomp.

Do we have any previous fix/docs I can refer to? Thanks!

[cz2h]

Hi @eellison , @jansel . Could you take a look at this quick fix? It should be able to pass all complex related tests now. Thanks in advanced!

[jansel]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

[cz2h]

Thanks so much for the quick response @jansel , the tests have passed, could you help me merge the change? Thanks a lot!

[jansel]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here