-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ROCm] Updated default workspace for gfx95 #153988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Updated default workspace for gfx95 #153988
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153988
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit a30caff with merge base 2b43d63 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Only basic CI is needed here since gfx950 is not in our public CI. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
@pytorchbot merge -f "it is not possible for this PR to affect any current CI flows" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Inductor hud is broken since this pr: https://hud.pytorch.org/hud/pytorch/pytorch/main/2?per_page=50&mergeEphemeralLF=true. Should we revert ? |
@eellison I don't see how the inductor hud for cuda could break with this change? The one-line change in this PR is already inside an
|
@eellison looks like torchao is failing to build suddenly, but not due to this PR. |
Fixes test_cuda.py::test_cublas_workspace_explicit_allocation on gfx95 Pull Request resolved: pytorch#153988 Approved by: https://github.com/jeffdaily
Fixes test_cuda.py::test_cublas_workspace_explicit_allocation on gfx95
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd