[Minimizer] Gracefully exit when there is no discrepancy in block mode #154076
Conversation
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @AutinMitra, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
|
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154076
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f3cf399 with merge base 5bb156a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D75143242 |
AutinMitra
force-pushed
the
export-D75143242
branch
from
563ceea to
a6fb1c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75143242 |
AutinMitra
force-pushed
the
export-D75143242
branch
from
a6fb1c9 to
dbfe363
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75143242 |
AutinMitra
force-pushed
the
export-D75143242
branch
from
dbfe363 to
7abfa24
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75143242 |
AutinMitra
force-pushed
the
export-D75143242
branch
from
7abfa24 to
84cd9b6
Compare
AutinMitra
force-pushed
the
export-D75143242
branch
from
84cd9b6 to
592baa7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75143242 |
AutinMitra
force-pushed
the
export-D75143242
branch
from
592baa7 to
089f8ed
Compare
pytorch#154076) Summary: Pull Request resolved: pytorch#154076 Previously, when there is no discrepancy in results for block mode, net_min_base will throw an OOB error. This occurs due to the block _block_traverse_impl returning an OOB after exhausting subgraphs all the way down to a single node There is also an issue where we may get an unsound subgraph (i.e. mark an earlier node as the "end" even if the correct end is later). This is due to an incorrect check (start_idx == mid) where there can possibly be two values left before the program pre-maturely returns Test Plan: buck test fbcode//caffe2/test:fx_minimizer File changed: fbcode//caffe2/test/TARGETS Buck UI: https://www.internalfb.com/buck2/d56adebc-a10d-477c-9b69-70d91d235c5d Test UI: https://www.internalfb.com/intern/testinfra/testrun/11258999153892410 Network: Up: 8.4KiB Down: 0B (reSessionID-b82b8e89-5546-407d-a2c4-bd671dd20bfe) Loading targets. Remaining 0/1 1335 targets declared Analyzing targets. Remaining 0/6 48 actions, 55 artifacts declared Executing actions. Remaining 0/40 2.9s exec time total Command: test. Finished 4 local Time elapsed: 48.5s Tests finished: Pass 7. Fail 0. Fatal 0. Skip 0. Build failure 0 Reviewed By: qcyuan Differential Revision: D75143242
|
This pull request was exported from Phabricator. Differential Revision: D75143242 |
AutinMitra
force-pushed
the
export-D75143242
branch
from
089f8ed to
f3cf399
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Summary:
Previously, when there is no discrepancy in results for block mode, net_min_base will throw an OOB error.
This occurs due to the block _block_traverse_impl returning an OOB after exhausting subgraphs all the way down to a single node
There is also an issue where we may get an unsound subgraph (i.e. mark an earlier node as the "end" even if the correct end is later). This is due to an incorrect check (start_idx == mid) where there can possibly be two values left before the program pre-maturely returns
Test Plan:
Buck UI: https://www.internalfb.com/buck2/52524c26-ace5-4593-8a4b-843a54eb206a
Test UI: https://www.internalfb.com/intern/testinfra/testrun/3096224973363310
Network: Up: 0B Down: 15MiB (reSessionID-cd404e97-395f-49fc-8381-373e90a1378f)
Executing actions. Remaining 0/1
Command: test.
Time elapsed: 53.7s
Tests finished: Pass 7. Fail 0. Fatal 0. Skip 0. Build failure 0
Differential Revision: D75143242
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv