Skip to content

Conversation

…==4.44.2.

This PR add a attention fusion pattern that match the attention of
DistilDistilBert in transformers==4.44.2 at
https://github.com/huggingface/transformers/blob/953196a43dae6a3c474165fba7d215fcbc7b7730/src/transformers/models/distilbert/modeling_distilbert.py#L212

Signed-off-by: xinan.lin <xinan.lin@intel.com>

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154091

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (2 Unrelated Failures)

As of commit 7a071e7 with merge base 6cb6da6 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

etaf added a commit that referenced this pull request May 22, 2025
…==4.44.2.

This PR add a attention fusion pattern that match the attention of
DistilDistilBert in transformers==4.44.2 at
https://github.com/huggingface/transformers/blob/953196a43dae6a3c474165fba7d215fcbc7b7730/src/transformers/models/distilbert/modeling_distilbert.py#L212

Signed-off-by: xinan.lin <xinan.linintel.com>

ghstack-source-id: 1cdd0b3
Pull Request resolved: #154091
@etaf etaf requested a review from EikanWang May 22, 2025 01:06
@etaf etaf added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels May 22, 2025
@etaf etaf requested review from eellison and jansel May 22, 2025 05:41
@etaf
Copy link
Collaborator Author

etaf commented May 22, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@seemethere
Copy link
Member

@pytorchbot revert -c ghfirst -m "I root caused this PR to some failures, I tried to resolve with #154923 but it looks like there are more failures with my fix"

For a simple fix / follow-up to this all you have to do is re-run python3 torchgen/fuse/gen_patterns.py

Sorry for the churn here this just made things difficult to land!

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jun 2, 2025
…sformers==4.44.2. (#154091)"

This reverts commit 7b25ff7.

Reverted #154091 on behalf of https://github.com/seemethere due to I root caused this PR to some failures, I tried to resolve with #154923 but it looks like there are more failures with my fix ([comment](#154091 (comment)))
@pytorchmergebot
Copy link
Collaborator

@etaf your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jun 2, 2025
…ransformers==4.44.2."


This PR add a attention fusion pattern that match the attention of
DistilDistilBert in transformers==4.44.2 at
https://github.com/huggingface/transformers/blob/953196a43dae6a3c474165fba7d215fcbc7b7730/src/transformers/models/distilbert/modeling_distilbert.py#L212

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
etaf added 2 commits June 2, 2025 23:21
…ransformers==4.44.2."


This PR add a attention fusion pattern that match the attention of
DistilDistilBert in transformers==4.44.2 at
https://github.com/huggingface/transformers/blob/953196a43dae6a3c474165fba7d215fcbc7b7730/src/transformers/models/distilbert/modeling_distilbert.py#L212

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
…ransformers==4.44.2."


This PR add a attention fusion pattern that match the attention of
DistilDistilBert in transformers==4.44.2 at
https://github.com/huggingface/transformers/blob/953196a43dae6a3c474165fba7d215fcbc7b7730/src/transformers/models/distilbert/modeling_distilbert.py#L212

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154110

iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull request Jun 4, 2025
…sformers==4.44.2. (pytorch#154091)"

This reverts commit 7b25ff7.

Reverted pytorch#154091 on behalf of https://github.com/seemethere due to I root caused this PR to some failures, I tried to resolve with pytorch#154923 but it looks like there are more failures with my fix ([comment](pytorch#154091 (comment)))
iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull request Jun 4, 2025
angelayi pushed a commit to angelayi/pytorch that referenced this pull request Jun 5, 2025
@github-actions github-actions bot deleted the gh/etaf/128/head branch July 4, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants