Remove caffe2::Tensor copy constructor #15416
Closed
+61
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhulgakov
force-pushed
the
export-D13524598
branch
from
cec720d to
9614eef
Compare
dzhulgakov
force-pushed
the
export-D13524598
branch
from
9614eef to
78e1d50
Compare
Summary: Based on offline discussion it should be less surprising to the users of existing code. Thus caffe2::Tensor is now a move-only class (as it used to be), explicit calls to UnsafeSharedInstance() are necessary to get shared_ptr behavior. This change also identified a few places that misused the copy constructor - those are fixed Pull Request resolved: pytorch#15416 Reviewed By: Yangqing Differential Revision: D13524598 fbshipit-source-id: b659a40abc107e62fe3291792c550d817bc7bc07
dzhulgakov
force-pushed
the
export-D13524598
branch
from
78e1d50 to
56b42a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D13524598