Switch to _apply_to_tensors for dataclass input #154897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154897
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 1 PendingAs of commit e4ba9f0 with merge base 4014297 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
oncall: distributed
weifengpy
reviewed
Jun 3, 2025
| mp_policy = MixedPrecisionPolicy( | ||
| torch.bfloat16, torch.bfloat16, torch.bfloat16, True | ||
| ) | ||
| model = Model().cuda() |
There was a problem hiding this comment.
no need for .cuda(), because fully_shard moves model to cuda
weifengpy
reviewed
Jun 3, 2025
| super().__init__(*args, **kwargs) | ||
| self._layer = nn.Linear(10, 10) | ||
|
|
||
| def forward(self, input: torch.Tensor): |
There was a problem hiding this comment.
input: torch.Tensor -> input: Input ?
weifengpy
approved these changes
Jun 3, 2025
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
Fixes pytorch#153077 Pull Request resolved: pytorch#154897 Approved by: https://github.com/weifengpy
angelayi
pushed a commit
to angelayi/pytorch
that referenced
this pull request
Jun 5, 2025
Fixes pytorch#153077 Pull Request resolved: pytorch#154897 Approved by: https://github.com/weifengpy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153077
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k