[dict] Implement dict.__ior__ and fix return type in dict.__or__ #155072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155072
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9021600 with merge base 6598f00 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 4, 2025
This was referenced Jun 9, 2025
zou3519
reviewed
Jul 31, 2025
anijain2305
approved these changes
Aug 21, 2025
|
Starting merge as part of PR stack under #155153 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 27, 2025
…155152) Pull Request resolved: #155152 Approved by: https://github.com/anijain2305 ghstack dependencies: #160156, #155072
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 27, 2025
Pull Request resolved: #155153 Approved by: https://github.com/anijain2305 ghstack dependencies: #160156, #155072, #155152
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…orch#155072) Pull Request resolved: pytorch#155072 Approved by: https://github.com/anijain2305 ghstack dependencies: pytorch#160156
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…ytorch#155152) Pull Request resolved: pytorch#155152 Approved by: https://github.com/anijain2305 ghstack dependencies: pytorch#160156, pytorch#155072
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Pull Request resolved: pytorch#155153 Approved by: https://github.com/anijain2305 ghstack dependencies: pytorch#160156, pytorch#155072, pytorch#155152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
dict.update()with no args #158061fromkeysclassmethod #155608bool(OrderedDict)#155503hasattr(..., IteratorVariable)#155501__eq__for dict_items #155154OrderedDict.popitem(last=...)#155153OrderedDict.move_to_end(key, last=False)#155152set_fullgraph(False)intest_dict/test_ordered_dict#160156cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela