Skip to content

[reland][dynamo] Mark a vt unspecialized nn module variable source earlier #155099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[reland][dynamo] Mark a vt unspecialized nn module variable source earlier #155099

wants to merge 1 commit into from

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Jun 4, 2025 •
edited
Loading

@anijain2305 anijain2305 requested a review from zou3519 as a code owner June 4, 2025 05:09
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155099

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit dfeb6ba with merge base 8f08f90 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anijain2305 anijain2305 changed the title [reland][dynamo] Mark a vt unspecialized nn module variable source ea… [reland][dynamo] Mark a vt unspecialized nn module variable source earlier Jun 4, 2025
@facebook-github-bot
Copy link
Contributor

@anijain2305 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 4, 2025
@anijain2305 anijain2305 force-pushed the reland-mark-source branch from 1b7f9f2 to e4a2ed0 Compare June 4, 2025 06:08
@anijain2305 anijain2305 added the topic: not user facing topic category label Jun 4, 2025
@facebook-github-bot
Copy link
Contributor

@anijain2305 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@anijain2305 anijain2305 force-pushed the reland-mark-source branch from e4a2ed0 to dfeb6ba Compare June 4, 2025 16:38
@facebook-github-bot
Copy link
Contributor

@anijain2305 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@anijain2305 anijain2305 requested review from StrongerXi and jansel June 4, 2025 16:51
@anijain2305 anijain2305 mentioned this pull request Jun 4, 2025
Closed
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Jun 4, 2025
@anijain2305 @facebook-github-bot
Mark a vt unspecialized nn module variable source earlier
73c93cf 
Summary:
Reland of pytorch/pytorch#154780

Fixes #ISSUE_NUMBER

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

X-link: pytorch/pytorch#155099

Reviewed By: williamwen42

Differential Revision: D75928791

Pulled By: anijain2305

fbshipit-source-id: 55f8a214e3b0ff573dd1bdd1fb5fb34a220a620d
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

angelayi pushed a commit to angelayi/pytorch that referenced this pull request Jun 5, 2025
@anijain2305 @angelayi
[reland][dynamo] Mark a vt unspecialized nn module variable source ea…
f61543f 
…rlier (pytorch#155099)

Reland of pytorch#154780

Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#155099
Approved by: https://github.com/williamwen42
@github-actions github-actions bot deleted the reland-mark-source branch July 6, 2025 02:21
StrongerXi
StrongerXi reviewed Sep 12, 2025
View reviewed changes
torch/_dynamo/utils.py
Comment on lines +2405 to +2408
or (
source.guard_source().is_unspecialized_nn_module()
and not config.allow_unspec_int_on_nn_module
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this was intended from the get-go (i.e., specialize on int attr of all nn modules, not just the global ones). Regardless, adding this caused extra recompilations which didn't exist before 2.8: #161372.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is intended. This removes the inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StrongerXi StrongerXi StrongerXi left review comments

@williamwen42 williamwen42 williamwen42 approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519 zou3519 is a code owner

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anijain2305 @facebook-github-bot @pytorchmergebot @williamwen42 @StrongerXi