-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[jit] clang format jit #15524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jit] clang format jit #15524
Conversation
5dbf34f to
757f76f
Compare
757f76f to
6d592ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suo is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand we still don't enforce clang-format on all files, nor did we even let people write some PR agains the partial check. Maybe it's better to wait for results of that before we merge a 10k line patch that doesn't do anything?
|
The enforcement (such as it is) is done through the precommit hook. It's not hard enforcement, but I'm trying to get the codebase in a reasonable state before then. I can do things more incrementally, but it seems like that will probably be more pain for everyone involved (lots of rebasing and merge conflicts rather than ripping the bandaid off when few people have outstanding PRs).
Do you mean that we haven't tested the hook enough? |
|
Spoke offline with @apaszke and we decided to go ahead with band-aid ripping, followed by a warning CI check as well |
The PR clang-formats everything in
torch/csrc/jit/and adds it to the pre-commit hook.Here is a list of non-mechanical changes: