Make the warning suppression safer #15560
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
approved these changes
Dec 27, 2018
Maratyszcza
approved these changes
Dec 27, 2018
peterjc123
force-pushed
the
warning_fix
branch
from
69d079c to
cb29583
Compare
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
peterjc123
added a commit
to peterjc123/pytorch
that referenced
this pull request
Jan 17, 2019
Summary: Address the problem introduced in pytorch#15499 (comment). Pull Request resolved: pytorch#15560 Differential Revision: D13561346 Pulled By: soumith fbshipit-source-id: 6abf622672bdcb77ae1a7188e8a3817fa97aecbc
soumith
added
the
cherry-picked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the problem introduced in #15499 (comment).