convert jit_language_reference.rst to jit_language_reference.md #155633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155633
Note: Links to docs will display an error until the docs builds have been completed. ❌ 29 New Failures, 6 Cancelled Jobs, 1 Unrelated FailureAs of commit fb99480 with merge base bb43ced ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
reviewed
Jun 10, 2025
|
|
||
| .. _module attributes: | ||
| (module-attributes)= | ||
| (Module Attributes)= |
There was a problem hiding this comment.
Suggested change
| (Module Attributes)= |
There was a problem hiding this comment.
there's a :any: at line 146, not sure whether deleting (Module Attributes)= will break that reference
Comment on lines
+335
to
+352
| > For example, assigning to `self` outside of the `__init__()` method: | ||
| > | ||
| > ``` | ||
| > @torch.jit.script | ||
| > class Foo: | ||
| > def assign_x(self): | ||
| > self.x = torch.rand(2, 3) | ||
| > ``` | ||
| > | ||
| > Will result in: | ||
| > | ||
| > ``` | ||
| > RuntimeError: | ||
| > Tried to set nonexistent attribute: x. Did you forget to initialize it in __init__()?: | ||
| > def assign_x(self): | ||
| > self.x = torch.rand(2, 3) | ||
| > ~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE | ||
| > ``` |
There was a problem hiding this comment.
Not sure why there is a leading > here. Can you explain?
There was a problem hiding this comment.
It's for the code block to be visually aligned with the bullet point and it's rendered like this:
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Rachel0619
changed the title
|
@pytorchbot label "topic: docs" |
janeyx99
added
the
triaged
|
@pytorchbot merge -f "Docs only change. Do signal is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
thatgeeman
reviewed
Jun 15, 2025
| ``` | ||
|
|
||
| .. _language-reference: | ||
| (language-reference)= |
There was a problem hiding this comment.
@Rachel0619 shouldnt this be jit_language_reference?
based on a reference here: https://raw.githubusercontent.com/pytorch/pytorch/refs/heads/main/docs/source/jit.rst
CC: @svekars
There was a problem hiding this comment.
Hi @thatgeeman I think in the below code (if that's what you are referring to), they are referencing jit_language_reference.md file and jit_language_reference_v2.md file instead of the headings.
CC: @svekars
.. toctree::
:maxdepth: 1
:caption: Language Reference
:hidden:
jit_language_reference
.. toctree::
:maxdepth: 1
jit_language_reference_v2
|
Yes that's true, that's for the clarification (y)
…On Mon, Jun 16, 2025, 06:37 Runtian (Rachel) Li ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/source/jit_language_reference.md
<#155633 (comment)>:
>
-.. _language-reference:
+(language-reference)=
Hi @thatgeeman <https://github.com/thatgeeman> I think in the below code
(if that's what you are referring to), they are referencing
jit_language_reference.md file and jit_language_reference_v2.md file
instead of the headings.
CC: @svekars <https://github.com/svekars>
.. toctree::
:maxdepth: 1
:caption: Language Reference
:hidden:
jit_language_reference
.. toctree::
:maxdepth: 1
jit_language_reference_v2
—
Reply to this email directly, view it on GitHub
<#155633 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCJVYMTMN4NKZPID2WZJAT3DZCYBAVCNFSM6AAAAAB7A5HBK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZQGYYDMMRUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of changes #155023 (parent PR #155429)
@pytorchbot label "topic: docs"
@pytorchbot label "topic: not user facing"
@pytorchbot label docathon-h1-2025
@pytorchbot label module: docs