Skip to content

Conversation

laithsakka
Copy link
Contributor

@laithsakka laithsakka commented Jun 13, 2025

Stack from ghstack (oldest at bottom):

preserve current behavior. Generalize it such that no need for torch._check_is_size to opt into this,
and make it work for more complex unbacked sizes with ranges [-inf, inf]

Copy link

pytorch-bot bot commented Jun 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155869

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit b788124 with merge base 4d3ecef (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

laithsakka added a commit that referenced this pull request Jun 13, 2025
ghstack-source-id: fb237f3
Pull Request resolved: #155869
@laithsakka laithsakka changed the title assume sparse tensor not coalesced_ [DRAFT] assume sparse tensor not coalesced_ gsv -> guard_or_false. Jun 13, 2025
@laithsakka laithsakka requested a review from IvanKobzarev June 13, 2025 00:31
@laithsakka laithsakka added the topic: not user facing topic category label Jun 13, 2025
@laithsakka laithsakka requested a review from bobrenjc93 June 13, 2025 03:38
@laithsakka laithsakka changed the title [DRAFT] assume sparse tensor not coalesced_ gsv -> guard_or_false. assume sparse tensor not coalesced_ gsv -> guard_or_false. Jun 13, 2025
@laithsakka
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 13, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / verify-cachebench-cpu-build / build

Details for Dev Infra team Raised by workflow job

@laithsakka
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / verify-cachebench-cpu-build / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/laithsakka/216/head branch July 15, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants