consolidate in finish step #155940
Closed
consolidate in finish step #155940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/) [ghstack-poisoned]
This was referenced Jun 13, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155940
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 33 PendingAs of commit 9696fce with merge base 08dae94 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
ankitageorge
added a commit
that referenced
this pull request
Jun 13, 2025
Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/) ghstack-source-id: 290317312 Pull Request resolved: #155940
|
This pull request was exported from Phabricator. Differential Revision: D76602613 |
Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 24, 2025
…h step Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Pull Request resolved: #155940 ghstack-source-id: 292259595 @exported-using-ghexport Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/)
|
This pull request was exported from Phabricator. Differential Revision: D76602613 |
Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 24, 2025
…h step Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Pull Request resolved: #155940 ghstack-source-id: 292339908 @exported-using-ghexport Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/)
|
This pull request was exported from Phabricator. Differential Revision: D76602613 |
Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 24, 2025
…h step Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Pull Request resolved: #155940 ghstack-source-id: 292340529 @exported-using-ghexport Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/)
|
This pull request was exported from Phabricator. Differential Revision: D76602613 |
Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 24, 2025
…h step Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Pull Request resolved: #155940 ghstack-source-id: 292346941 @exported-using-ghexport Differential Revision: [D76602613](https://our.internmc.facebook.com/intern/diff/D76602613/)
|
This pull request was exported from Phabricator. Differential Revision: D76602613 |
ankitageorge
added a commit
that referenced
this pull request
Jun 24, 2025
…h step Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 24, 2025
…h step Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) ghstack-source-id: 292353372 Pull Request resolved: #156705
|
closing b/c this got into a bad detached state and re-creating in #156705 |
ankitageorge
added a commit
that referenced
this pull request
Jun 24, 2025
…rs in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 24, 2025
…h step Pull Request resolved: #156705 Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state ghstack-source-id: 292356884 @exported-using-ghexport Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/)
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…h step Pull Request resolved: #156705 Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state ghstack-source-id: 293476800 @exported-using-ghexport Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/)
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…es to full tensors in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…rs in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…es to full tensors in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…rs in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…h step Pull Request resolved: #156705 Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state ghstack-source-id: 293491492 @exported-using-ghexport Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/)
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…es to full tensors in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…rs in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…h step Pull Request resolved: #156705 Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state ghstack-source-id: 293497464 @exported-using-ghexport Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/)
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…es to full tensors in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…rs in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jun 30, 2025
…h step Pull Request resolved: #156705 Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state ghstack-source-id: 293520075 @exported-using-ghexport Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/)
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 1, 2025
…h step (#156705) Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) Pull Request resolved: #156705 Approved by: https://github.com/saumishr ghstack dependencies: #154743
ankitageorge
added a commit
that referenced
this pull request
Jul 1, 2025
…es to full tensors in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Jul 1, 2025
…rs in finish step" Title - we can consolidate the shards to a full tensors, optionally behind a flag, in the finish step of DCP.save also adds the thread count argument which is configurable for users, before we were just using the default of 1. Re-creating #155940 bc it got into a bad detached state Differential Revision: [D77231774](https://our.internmc.facebook.com/intern/diff/D77231774/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D76602613
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k