Skip to content

[iter] support iter(callable, sentinel) #156416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

[iter] support iter(callable, sentinel) #156416

wants to merge 22 commits into from

Conversation

guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Jun 19, 2025 •
edited by pytorch-bot bot
Loading

@guilhermeleobas
Update
1624d01 
[ghstack-poisoned]
This was referenced Jun 19, 2025
Closed
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156416

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 4965a5e with merge base 9d32aa9 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guilhermeleobas guilhermeleobas mentioned this pull request Jun 19, 2025
Closed
guilhermeleobas added a commit that referenced this pull request Jun 19, 2025
@guilhermeleobas
[iter] support iter(callable, sentinel)
9bc764b 
ghstack-source-id: 4d735b8
Pull Request resolved: #156416
@guilhermeleobas
Update
4e90066 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request Jun 20, 2025
Closed
XuehaiPan
XuehaiPan reviewed Jun 20, 2025
View reviewed changes
guilhermeleobas and others added 6 commits June 20, 2025 14:34
@guilhermeleobas
Update
0ae22cf 
[ghstack-poisoned]
@guilhermeleobas
Update
7eb7ce4 
[ghstack-poisoned]
@guilhermeleobas
Update
bd596c1 
[ghstack-poisoned]
@guilhermeleobas
Update
563445c 
[ghstack-poisoned]
@guilhermeleobas
Update
db5c68e 
[ghstack-poisoned]
@guilhermeleobas
Update
2e73faa 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas marked this pull request as ready for review June 24, 2025 13:30
guilhermeleobas and others added 3 commits June 24, 2025 17:41
@guilhermeleobas
Update
469fbeb 
[ghstack-poisoned]
@guilhermeleobas
Update
a549396 
[ghstack-poisoned]
@guilhermeleobas
Update
c9d5550 
[ghstack-poisoned]
XuehaiPan
XuehaiPan reviewed Jul 10, 2025
View reviewed changes
XuehaiPan
XuehaiPan reviewed Jul 10, 2025
View reviewed changes
@guilhermeleobas
Update
09b9457 
[ghstack-poisoned]
@guilhermeleobas
Update
b0b6c28 
[ghstack-poisoned]
@guilhermeleobas
Update
8919d1b 
[ghstack-poisoned]
@guilhermeleobas
Update
6118499 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request Jul 16, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

Rebased gh/guilhermeleobas/206/orig onto refs/remotes/origin/viable/strict because #158410 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/156416)

This was referenced Jul 18, 2025
Closed
Closed
@guilhermeleobas
Update
3dff562 
[ghstack-poisoned]
@guilhermeleobas
Update
342998b 
[ghstack-poisoned]
rtimpe pushed a commit to rtimpe/pytorch that referenced this pull request Jul 24, 2025
@guilhermeleobas @rtimpe
[iter] support iter(callable, sentinel)
ce3ded8 
ghstack-source-id: 8f7498b
Pull Request resolved: pytorch#156416
@rtimpe rtimpe mentioned this pull request Jul 24, 2025
Closed
@guilhermeleobas
Update
0d7164b 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #156460

@guilhermeleobas
Update
abd4511 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158410

@guilhermeleobas
Update
96f33a7 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/guilhermeleobas/206/orig onto refs/remotes/origin/main because #158410 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/156416)

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158410

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #156460

@guilhermeleobas
Update
4965a5e 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/guilhermeleobas/206/orig onto refs/remotes/origin/main because #158410 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/156416)

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158410

@guilhermeleobas guilhermeleobas mentioned this pull request Jul 29, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158410

pytorchmergebot pushed a commit that referenced this pull request Jul 29, 2025
@guilhermeleobas @pytorchmergebot
[iter] Wrap iter(..) call in a ObjectIteratorVariable (#156460)
f9be65c 
This object keeps track when the iterator is exhausted (raise Stopiteration).

Pull Request resolved: #156460
Approved by: https://github.com/zou3519
ghstack dependencies: #156371, #156416
pytorchmergebot pushed a commit that referenced this pull request Jul 29, 2025
@guilhermeleobas @pytorchmergebot
[iter] Raise TypeError if iter arg cannot be iterable (#158410)
b97274e 
Pull Request resolved: #158410
Approved by: https://github.com/XuehaiPan, https://github.com/zou3519
ghstack dependencies: #156371, #156416, #156460
yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@guilhermeleobas @yangw-dev
[iter] support iter(callable, sentinel) (#156416)
32e1948 
Pull Request resolved: #156416
Approved by: https://github.com/XuehaiPan, https://github.com/zou3519
ghstack dependencies: #156371
yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@guilhermeleobas @yangw-dev
[iter] Wrap iter(..) call in a ObjectIteratorVariable (#156460)
802b802 
This object keeps track when the iterator is exhausted (raise Stopiteration).

Pull Request resolved: #156460
Approved by: https://github.com/zou3519
ghstack dependencies: #156371, #156416
yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@guilhermeleobas @yangw-dev
[iter] Raise TypeError if iter arg cannot be iterable (#158410)
d9d3162 
Pull Request resolved: #158410
Approved by: https://github.com/XuehaiPan, https://github.com/zou3519
ghstack dependencies: #156371, #156416, #156460
@github-actions github-actions bot deleted the gh/guilhermeleobas/184/head branch August 29, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

@XuehaiPan XuehaiPan XuehaiPan approved these changes

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo open source release notes: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guilhermeleobas @pytorchmergebot @zou3519 @XuehaiPan @pytorchbot