Skip to content

Conversation

morrison-turnansky
Copy link
Contributor

@morrison-turnansky morrison-turnansky commented Jun 23, 2025

Fixes #156489
removed deprecated numpy plugin in mypy.ini
@ezyang

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156601

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit d8ed1a0 with merge base f5e1b24 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 23, 2025
@morrison-turnansky morrison-turnansky marked this pull request as ready for review June 23, 2025 15:48
@ezyang
Copy link
Contributor

ezyang commented Jun 24, 2025

I think this will probably cause some typing failures now though

@ezyang
Copy link
Contributor

ezyang commented Jun 24, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 24, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@morrison-turnansky morrison-turnansky deleted the issue-156489-mpy-numpy-deprecation branch June 26, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mypy.ini deprecation: numpy.typing.mypy_plugin

4 participants