[jit] Allow List arguments to Python Ops #15721
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2019 17:26
Adds `List` to eval environment for type lines for better error messages
facebook-github-bot
added
the
oncall: jit
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zou3519
reviewed
Jan 7, 2019
| }); | ||
| py::class_<ListType, Type, std::shared_ptr<ListType>>(m, "ListType") | ||
| .def( | ||
| py::init([](TypePtr a) { return ListType::create(a); })) |
There was a problem hiding this comment.
Did you mean to change the permissions on this file (I think that's what these numbers are?)
There was a problem hiding this comment.
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Listto eval environment for type lines and allowsListto be used on PythonOps (follows the same style as theTuplecode), fixes #15661