Skip to content

Make the name assert actually do something, and reserve some more names #157342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make the name assert actually do something, and reserve some more names #157342

wants to merge 1 commit into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Jul 1, 2025 •
edited
Loading

@ezyang
Update
b672eb7 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157342

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b672eb7 with merge base c174f3a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Jul 1, 2025
@ezyang
Make the name assert actually do something, and reserve some more names
a0296e0 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 22156e7
Pull-Request: #157342
@ezyang ezyang added the topic: not user facing topic category label Jul 5, 2025
@ezyang ezyang requested a review from jamesjwu July 5, 2025 12:26
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 5, 2025
albanD
albanD approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol
I guess there was no testing for this?

@ezyang
Copy link
Contributor Author

ezyang commented Jul 10, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/ezyang/3087/head branch August 9, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@jamesjwu jamesjwu Awaiting requested review from jamesjwu

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @pytorchmergebot @albanD