Skip to content

Conversation

yushangdi
Copy link
Contributor

@yushangdi yushangdi commented Jul 7, 2025

Summary: When compile_standalone is True, we set package_cpp_only to True as well. We raise an error if package_cpp_only is explicitly set to False in config.

Test Plan:

buck2 run  mode/dev-nosan fbcode//caffe2/test/inductor:test_aot_inductor -- -r  TestAOTInductorConfig

Rollback Plan:

Differential Revision: D77889754

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

Copy link

pytorch-bot bot commented Jul 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157731

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 85db368 with merge base 5b4e025 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77889754

@yushangdi yushangdi requested a review from desertfire July 7, 2025 20:45
yushangdi added a commit to yushangdi/pytorch that referenced this pull request Jul 7, 2025
Summary:

When `compile_standalone` is True, we set `package_cpp_only` to True as well. We raise an error if  `package_cpp_only` is explicitly set to False in config.

Test Plan:
```
buck2 run  mode/dev-nosan fbcode//caffe2/test/inductor:test_aot_inductor -- -r  TestAOTInductorConfig
```

Rollback Plan:

Differential Revision: D77889754
@yushangdi yushangdi added the topic: not user facing topic category label Jul 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77889754

yushangdi added a commit to yushangdi/pytorch that referenced this pull request Jul 7, 2025
Summary:

When `compile_standalone` is True, we set `package_cpp_only` to True as well. We raise an error if  `package_cpp_only` is explicitly set to False in config.

Test Plan:
```
buck2 run  mode/dev-nosan fbcode//caffe2/test/inductor:test_aot_inductor -- -r  TestAOTInductorConfig
```

Rollback Plan:

Differential Revision: D77889754
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77889754

yushangdi added a commit to yushangdi/pytorch that referenced this pull request Jul 7, 2025
Summary:
Pull Request resolved: pytorch#157731

When `compile_standalone` is True, we set `package_cpp_only` to True as well. We raise an error if  `package_cpp_only` is explicitly set to False in config.

Test Plan:
```
buck2 run  mode/dev-nosan fbcode//caffe2/test/inductor:test_aot_inductor -- -r  TestAOTInductorConfig
```

Rollback Plan:

Differential Revision: D77889754
Summary:

When `compile_standalone` is True, we set `package_cpp_only` to True as well. We raise an error if  `package_cpp_only` is explicitly set to False in config.

Test Plan:
```
buck2 run  mode/dev-nosan fbcode//caffe2/test/inductor:test_aot_inductor -- -r  TestAOTInductorConfig
```

Rollback Plan:

Reviewed By: muchulee8

Differential Revision: D77889754
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77889754

@yushangdi yushangdi changed the title Adding aoti_standalone_config Adding aoti_standalone config Jul 8, 2025
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 8, 2025
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants