[Memory Snapshot] Fix Linter for Global Annotations flag in Snapshot #157858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We added the ability to make Annotating Global or Local based on an input flag in PyTorch but now we need to have this flag propogate in the plugin itself Test Plan: Ran snapshot with flag on and saw that the global registration happened instead of local registration Rollback Plan: Reviewed By: mzzchy Differential Revision: D77959409
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157858
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0f81b34 with merge base 2e14069 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D77959409 |
sraikund16
changed the title
sraikund16
added
release notes: profiler
mzzchy
approved these changes
Jul 9, 2025
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We added the ability to make Annotating Global or Local based on an input flag in PyTorch but didn't add the args to the linter
Reviewed By: mzzchy
Differential Revision: D77959409