Remove deprecated caffe2::Tensor APIs #15814
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryzh168
force-pushed
the
export-D12812029
branch
from
7d6e77b to
4a6bc88
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
4a6bc88 to
580e722
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
580e722 to
48036da
Compare
ezyang
approved these changes
Jan 9, 2019
bddppq
reviewed
Jan 9, 2019
|
@bddppq Yes I'm fixing them. |
jerryzh168
force-pushed
the
export-D12812029
branch
from
48036da to
bf2fd12
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
bf2fd12 to
7de0843
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
7de0843 to
dfad21a
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
dfad21a to
7a2c835
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
7a2c835 to
ca85461
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
ca85461 to
c92f8f3
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
c92f8f3 to
c6e8d72
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
c6e8d72 to
58da38f
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
58da38f to
2bf35e9
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
2bf35e9 to
3138e88
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
3138e88 to
6cbde89
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
6cbde89 to
a1597cf
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
a1597cf to
1d94824
Compare
jerryzh168
force-pushed
the
export-D12812029
branch
from
1d94824 to
90e01ad
Compare
Summary: Remaining fixes so that D12812029 will compile Differential Revision: D13535559 fbshipit-source-id: a9f701028a42d641288fd6e30f12c42050069c27
Summary: Pull Request resolved: pytorch#15814 Plan is to remove the APIs we want to deprecate one by one and make sure it still builds in sandcastle and ossci Reviewed By: ezyang Differential Revision: D12812029 fbshipit-source-id: adc64d6b8373b21e70be017f06bf36e578e20a96
jerryzh168
force-pushed
the
export-D12812029
branch
from
90e01ad to
f53c871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Plan is to remove the APIs we want to deprecate one by one and make sure it still builds in sandcastle and ossci
Reviewed By: ezyang
Differential Revision: D12812029