Skip to content

Conversation

jataylo
Copy link
Collaborator

@jataylo jataylo commented Jul 17, 2025

This reverts commit 8554c80 #157563 due to causing a few breakages on ROCm

Reverted expected_results.csv to 26807dc

@xuanzhang816 Sorry, but I have to revert this PR yet again because it clearly reintroduced failures on ROCm after the remerge: https://hud.pytorch.org/hud/pytorch/pytorch/f4d8bc46c7706f872abcb4ec41f0b32207d5d826/2?per_page=50&name_filter=rocm-mi300&mergeEphemeralLF=true
and the failures are still showing up on tip-of-tree on HUD

Context
#157563 (comment)

Needs to be relanded in non bc-breaking way, or sanity checked for correctness.
cc: @xuanzhang816

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@jataylo jataylo requested review from huydhn and jithunnair-amd July 17, 2025 09:54
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158550

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (10 Unrelated Failures)

As of commit 7323802 with merge base eeda1a7 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jataylo jataylo added ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Jul 17, 2025
@jithunnair-amd jithunnair-amd added keep-going Don't stop on first failure, keep running tests until the end topic: not user facing topic category oncall: pt2 labels Jul 17, 2025
@jataylo
Copy link
Collaborator Author

jataylo commented Jul 17, 2025

test/inductor/test_max_autotune.py::TestMaxAutotune::test_linear_and_cel -

test/inductor/test_inplace_padding.py::InplacePaddingTest::test_linear_and_cel_max_autotune -

Passing post revert, failures are unrelated.

@jithunnair-amd
Copy link
Collaborator

@pytorchbot merge -f "This is a manual revert of PR 157563 to restore ROCm CI to green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 keep-going Don't stop on first failure, keep running tests until the end Merged module: dynamo module: inductor oncall: pt2 open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants